Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

Issue 2431253003: Remove now unused code in RtpHeaderExtensionMap (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 15 matching lines...) Expand all
26 26
27 const uint8_t RtpHeaderExtensionTest::kId = 3; 27 const uint8_t RtpHeaderExtensionTest::kId = 3;
28 28
29 TEST_F(RtpHeaderExtensionTest, Register) { 29 TEST_F(RtpHeaderExtensionTest, Register) {
30 EXPECT_EQ(0, map_.Size()); 30 EXPECT_EQ(0, map_.Size());
31 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 31 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
32 EXPECT_TRUE(map_.IsRegistered(kRtpExtensionTransmissionTimeOffset)); 32 EXPECT_TRUE(map_.IsRegistered(kRtpExtensionTransmissionTimeOffset));
33 EXPECT_EQ(1, map_.Size()); 33 EXPECT_EQ(1, map_.Size());
34 EXPECT_EQ(0, map_.Deregister(kRtpExtensionTransmissionTimeOffset)); 34 EXPECT_EQ(0, map_.Deregister(kRtpExtensionTransmissionTimeOffset));
35 EXPECT_EQ(0, map_.Size()); 35 EXPECT_EQ(0, map_.Size());
36
37 EXPECT_EQ(0, map_.RegisterInactive(kRtpExtensionTransmissionTimeOffset, kId));
38 EXPECT_EQ(0, map_.Size());
39 EXPECT_TRUE(map_.IsRegistered(kRtpExtensionTransmissionTimeOffset));
40 EXPECT_TRUE(map_.SetActive(kRtpExtensionTransmissionTimeOffset, true));
41 EXPECT_EQ(1, map_.Size());
42 } 36 }
43 37
44 TEST_F(RtpHeaderExtensionTest, RegisterIllegalArg) { 38 TEST_F(RtpHeaderExtensionTest, RegisterIllegalArg) {
45 // Valid range for id: [1-14]. 39 // Valid range for id: [1-14].
46 EXPECT_EQ(-1, map_.Register(kRtpExtensionTransmissionTimeOffset, 0)); 40 EXPECT_EQ(-1, map_.Register(kRtpExtensionTransmissionTimeOffset, 0));
47 EXPECT_EQ(-1, map_.Register(kRtpExtensionTransmissionTimeOffset, 15)); 41 EXPECT_EQ(-1, map_.Register(kRtpExtensionTransmissionTimeOffset, 15));
48 } 42 }
49 43
50 TEST_F(RtpHeaderExtensionTest, Idempotent) { 44 TEST_F(RtpHeaderExtensionTest, Idempotent) {
51 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 45 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
52 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 46 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
53 EXPECT_EQ(0, map_.Deregister(kRtpExtensionTransmissionTimeOffset)); 47 EXPECT_EQ(0, map_.Deregister(kRtpExtensionTransmissionTimeOffset));
54 EXPECT_EQ(0, map_.Deregister(kRtpExtensionTransmissionTimeOffset)); 48 EXPECT_EQ(0, map_.Deregister(kRtpExtensionTransmissionTimeOffset));
55 } 49 }
56 50
57 TEST_F(RtpHeaderExtensionTest, NonUniqueId) { 51 TEST_F(RtpHeaderExtensionTest, NonUniqueId) {
58 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 52 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
59 EXPECT_EQ(-1, map_.Register(kRtpExtensionAudioLevel, kId)); 53 EXPECT_EQ(-1, map_.Register(kRtpExtensionAudioLevel, kId));
60 EXPECT_EQ(-1, map_.RegisterInactive(kRtpExtensionAudioLevel, kId));
61 } 54 }
62 55
63 TEST_F(RtpHeaderExtensionTest, GetTotalLength) { 56 TEST_F(RtpHeaderExtensionTest, GetTotalLength) {
64 EXPECT_EQ(0u, map_.GetTotalLengthInBytes()); 57 EXPECT_EQ(0u, map_.GetTotalLengthInBytes());
65 EXPECT_EQ(0, map_.RegisterInactive(kRtpExtensionTransmissionTimeOffset, kId));
66 EXPECT_EQ(0u, map_.GetTotalLengthInBytes());
67
68 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 58 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
69 EXPECT_EQ(kRtpOneByteHeaderLength + kTransmissionTimeOffsetLength, 59 EXPECT_EQ(kRtpOneByteHeaderLength + kTransmissionTimeOffsetLength,
70 map_.GetTotalLengthInBytes()); 60 map_.GetTotalLengthInBytes());
71 } 61 }
72 62
73 TEST_F(RtpHeaderExtensionTest, GetLengthUntilBlockStart) {
74 EXPECT_EQ(-1, map_.GetLengthUntilBlockStartInBytes(
75 kRtpExtensionTransmissionTimeOffset));
76 EXPECT_EQ(0, map_.RegisterInactive(kRtpExtensionTransmissionTimeOffset, kId));
77 EXPECT_EQ(-1, map_.GetLengthUntilBlockStartInBytes(
78 kRtpExtensionTransmissionTimeOffset));
79
80 EXPECT_TRUE(map_.SetActive(kRtpExtensionTransmissionTimeOffset, true));
81 EXPECT_EQ(static_cast<int>(kRtpOneByteHeaderLength),
82 map_.GetLengthUntilBlockStartInBytes(
83 kRtpExtensionTransmissionTimeOffset));
84 }
85
86 TEST_F(RtpHeaderExtensionTest, GetType) { 63 TEST_F(RtpHeaderExtensionTest, GetType) {
87 RTPExtensionType typeOut; 64 RTPExtensionType typeOut;
88 EXPECT_EQ(-1, map_.GetType(kId, &typeOut)); 65 EXPECT_EQ(-1, map_.GetType(kId, &typeOut));
89 66
90 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 67 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
91 EXPECT_EQ(0, map_.GetType(kId, &typeOut)); 68 EXPECT_EQ(0, map_.GetType(kId, &typeOut));
92 EXPECT_EQ(kRtpExtensionTransmissionTimeOffset, typeOut); 69 EXPECT_EQ(kRtpExtensionTransmissionTimeOffset, typeOut);
93 } 70 }
94 71
95 TEST_F(RtpHeaderExtensionTest, GetId) { 72 TEST_F(RtpHeaderExtensionTest, GetId) {
96 uint8_t idOut; 73 uint8_t idOut;
97 EXPECT_EQ(-1, map_.GetId(kRtpExtensionTransmissionTimeOffset, &idOut)); 74 EXPECT_EQ(-1, map_.GetId(kRtpExtensionTransmissionTimeOffset, &idOut));
98 75
99 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 76 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
100 EXPECT_EQ(0, map_.GetId(kRtpExtensionTransmissionTimeOffset, &idOut)); 77 EXPECT_EQ(0, map_.GetId(kRtpExtensionTransmissionTimeOffset, &idOut));
101 EXPECT_EQ(kId, idOut); 78 EXPECT_EQ(kId, idOut);
102 } 79 }
103 80
104 TEST_F(RtpHeaderExtensionTest, IterateTypes) {
105 EXPECT_EQ(kRtpExtensionNone, map_.First());
106 EXPECT_EQ(kRtpExtensionNone, map_.Next(kRtpExtensionTransmissionTimeOffset));
107
108 EXPECT_EQ(0, map_.RegisterInactive(kRtpExtensionTransmissionTimeOffset, kId));
109
110 EXPECT_EQ(kRtpExtensionNone, map_.First());
111
112 EXPECT_TRUE(map_.SetActive(kRtpExtensionTransmissionTimeOffset, true));
113
114 EXPECT_EQ(kRtpExtensionTransmissionTimeOffset, map_.First());
115 EXPECT_EQ(kRtpExtensionNone, map_.Next(kRtpExtensionTransmissionTimeOffset));
116 }
117
118 TEST_F(RtpHeaderExtensionTest, GetCopy) { 81 TEST_F(RtpHeaderExtensionTest, GetCopy) {
119 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 82 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
120 83
121 RtpHeaderExtensionMap mapOut; 84 RtpHeaderExtensionMap mapOut;
122 map_.GetCopy(&mapOut); 85 map_.GetCopy(&mapOut);
123 EXPECT_EQ(1, mapOut.Size()); 86 EXPECT_EQ(1, mapOut.Size());
124 EXPECT_EQ(kRtpExtensionTransmissionTimeOffset, mapOut.First()); 87 EXPECT_EQ(kId, mapOut.GetId(kRtpExtensionTransmissionTimeOffset));
125 } 88 }
126 89
127 TEST_F(RtpHeaderExtensionTest, Erase) { 90 TEST_F(RtpHeaderExtensionTest, Erase) {
128 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId)); 91 EXPECT_EQ(0, map_.Register(kRtpExtensionTransmissionTimeOffset, kId));
129 EXPECT_EQ(1, map_.Size()); 92 EXPECT_EQ(1, map_.Size());
130 map_.Erase(); 93 map_.Erase();
131 EXPECT_EQ(0, map_.Size()); 94 EXPECT_EQ(0, map_.Size());
132 } 95 }
133 } // namespace webrtc 96 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698