Fix BWE simulations so that it uses the delay based BWE.

Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on loggging/rtc_event_log

BUG=webrtc:6526
NOPRESUBMIT=True

Committed: https://crrev.com/2d81eb33f5fe313ba36277067d2c9b77d1b6b54e
Cr-Commit-Position: refs/heads/master@{#14772}

[terelius, 2016-10-19 15:13:55]

terelius@webrtc.org changed reviewers:
+ brandtr@webrtc.org, stefan@webrtc.org

[terelius, 2016-10-19 15:13:56]

Please take a look.

Fredrik: webrtc/audio
Stefan/Rasmus: everything else

[stefan-webrtc, 2016-10-19 16:35:19]

https://codereview.webrtc.org/2431093003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc (right):

https://codereview.webrtc.org/2431093003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc:50:
kAbsSendTimeEstimator,
If you are ok with it I think we can simply remove the AbsSendTimeEstimator
since it's running the abs send time estimator on the send-side, which is not
something we use or will support.

[brandtr, 2016-10-20 08:00:31]

lgtm with nits.

Nits:
- Update the first line of the commit message to say that this CL adds support
for send-side BWE in the simulations. ("Fix" makes it sound like the simulations
were broken before. Were they?)
- Fix old spelling mistake.

General comments (not expecting any actions in this CL):
- I find the naming of the BW estimators to be a bit confusing. Sometimes I get
the feeling that send-side BWE and delay-based BWE are the same thing (for
example, in this class:
https://codereview.webrtc.org/2431093003/diff/1/webrtc/modules/remote_bitrate...),
but I've been told that they aren't.
- Perhaps the moving of the RtcEventLog mock could have been done in a separate
and parallel CL.

https://codereview.webrtc.org/2431093003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc (right):

https://codereview.webrtc.org/2431093003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc:336: // The following
test cases begin with "Evaluation" as a referrence to the
"reference"

[the sun, 2016-10-20 08:47:35]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-10-20 08:47:35]

lgtm for webrtc/audio/

[terelius, 2016-10-24 12:54:23]

https://codereview.chromium.org/2431093003/diff/1/webrtc/modules/remote_bitra...
File webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc (right):

https://codereview.chromium.org/2431093003/diff/1/webrtc/modules/remote_bitra...
webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc:50:
kAbsSendTimeEstimator,
On 2016/10/19 16:35:19, stefan-webrtc (holmer) wrote:
> If you are ok with it I think we can simply remove the AbsSendTimeEstimator
> since it's running the abs send time estimator on the send-side, which is not
> something we use or will support.

Done.

https://codereview.chromium.org/2431093003/diff/1/webrtc/modules/remote_bitra...
webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc:336: // The following
test cases begin with "Evaluation" as a referrence to the
On 2016/10/20 08:00:31, brandtr wrote:
> "reference"

Done.

[terelius, 2016-10-24 13:03:45]

On 2016/10/20 08:00:31, brandtr wrote:
> - Update the first line of the commit message to say that this CL adds support
> for send-side BWE in the simulations. ("Fix" makes it sound like the
simulations
> were broken before. Were they?)

I think "fix" is the right word. The simulations claimed to be using the send
side estimator, but were in fact using a receive side estimator in a deprecated
way. This meant that if you made changes to the current send-side estimator it
would have no effect on the "send side" bandwidth simulations.

> - Perhaps the moving of the RtcEventLog mock could have been done in a
separate
> and parallel CL.

Yeah, that might have been better. However, it would not have been in parallel
since the DEPS check was preventing me from uploading the CL. (Otherwise, I
wouldn't have moved the mock at all.)

[stefan-webrtc, 2016-10-24 13:11:28]

lgtm

[brandtr, 2016-10-24 13:38:09]

On 2016/10/24 13:03:45, terelius wrote:
> On 2016/10/20 08:00:31, brandtr wrote:
> > - Update the first line of the commit message to say that this CL adds
support
> > for send-side BWE in the simulations. ("Fix" makes it sound like the
> simulations
> > were broken before. Were they?)
> 
> I think "fix" is the right word. The simulations claimed to be using the send
> side estimator, but were in fact using a receive side estimator in a
deprecated
> way. This meant that if you made changes to the current send-side estimator it
> would have no effect on the "send side" bandwidth simulations.
> 
> > - Perhaps the moving of the RtcEventLog mock could have been done in a
> separate
> > and parallel CL.
> 
> Yeah, that might have been better. However, it would not have been in parallel
> since the DEPS check was preventing me from uploading the CL. (Otherwise, I
> wouldn't have moved the mock at all.)

Sounds good!

[terelius, 2016-10-24 14:15:48]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2016-10-24 14:15:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, brandtr@webrtc.org
Link to the patchset: https://codereview.chromium.org/2431093003/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2016-10-24 14:16:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 14:20:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 14:20:10]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9482)

[terelius, 2016-10-25 13:57:19]

Description was changed from

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kAbsSendTimeEstimator and FullBweSender ->
AbsSendTimeBweSender. Add new class SendSideBweSender (controlled by
kSendSideEstimator) that actually uses the send side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
==========

to

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
==========

[terelius, 2016-10-25 14:04:02]

Description was changed from

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
==========

to

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
NOPRESUBMIT=True
==========

[terelius, 2016-10-25 14:04:11]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-10-25 14:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-25 14:04:39]

Description was changed from

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
NOPRESUBMIT=True
==========

to

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-10-25 14:04:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 14:04:51]

Description was changed from

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
NOPRESUBMIT=True
==========

to

==========
Fix BWE simulations so that it uses the delay based BWE.

Rename kFullSendSideEstimator -> kSendSideEstimator and add new class
SendSideBweSender (controlled by kSendSideEstimator) that actually uses the send
side BWE.

Move the mock to logging/rtc_event_log/mock.
Allow congestion_controller, remote_bitrate_estimator and audio to depend on
loggging/rtc_event_log

BUG=webrtc:6526
NOPRESUBMIT=True

Committed: https://crrev.com/2d81eb33f5fe313ba36277067d2c9b77d1b6b54e
Cr-Commit-Position: refs/heads/master@{#14772}
==========

[commit-bot: I haz the power, 2016-10-25 14:04:52]

Patchset 3 (id:??) landed as
https://crrev.com/2d81eb33f5fe313ba36277067d2c9b77d1b6b54e
Cr-Commit-Position: refs/heads/master@{#14772}