Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 2430693002: Include ScreenCapturerAndroid in libjingle_peerconnection_java.jar (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, magjed_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Include ScreenCapturerAndroid in libjingle_peerconnection_java.jar This makes it possible for external applications to use this class. BUG=webrtc:6524 NOTRY=True Committed: https://crrev.com/73c5d4a083826160e7170b4c8d926e703ac8b372 Cr-Commit-Position: refs/heads/master@{#14679}

Patch Set 1 #

Patch Set 2 : Fix alphabetic ordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/api/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-18 14:12:38 UTC) #3
kjellander_webrtc
lgtm
4 years, 2 months ago (2016-10-18 18:57:00 UTC) #5
kjellander_webrtc
On 2016/10/18 18:57:00, kjellander_webrtc wrote: > lgtm (I updated the title since "the jar" sounded ...
4 years, 2 months ago (2016-10-18 18:58:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430693002/20001
4 years, 2 months ago (2016-10-19 09:29:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 09:46:22 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 09:46:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73c5d4a083826160e7170b4c8d926e703ac8b372
Cr-Commit-Position: refs/heads/master@{#14679}

Powered by Google App Engine
This is Rietveld 408576698