Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2430393003: Eliminate left shift of negative value by using multiplication instead (Closed)

Created:
4 years, 2 months ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Eliminate left shift of negative value by using multiplication instead BUG=chromium:655917 Committed: https://crrev.com/b60d1962d8e325e5a3f41fd6130269400e672f0c Cr-Commit-Position: refs/heads/master@{#14741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_coding/neteq/dtmf_tone_generator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
kwiberg-webrtc
4 years, 2 months ago (2016-10-19 11:45:27 UTC) #2
hlundin-webrtc
lgtm
4 years, 2 months ago (2016-10-21 05:06:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430393003/1
4 years, 2 months ago (2016-10-21 07:52:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-21 09:53:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430393003/1
4 years, 2 months ago (2016-10-21 12:53:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on ...
4 years, 2 months ago (2016-10-21 14:54:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430393003/1
4 years, 1 month ago (2016-10-24 09:15:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 11:18:49 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 11:18:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b60d1962d8e325e5a3f41fd6130269400e672f0c
Cr-Commit-Position: refs/heads/master@{#14741}

Powered by Google App Engine
This is Rietveld 408576698