Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2430353004: Revert of Move bitstream parser to more appropriate directory. (Closed)

Created:
4 years, 2 months ago by kthelgason
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move bitstream parser to more appropriate directory. (patchset #4 id:60001 of https://codereview.webrtc.org/2370853005/ ) Reason for revert: Breaks internal project Original issue's description: > Move current bitstream parser to more appropriate directory. > > This CL groups together the code that has to do with parsing H264 bitstreams. > This code logically belongs together, and having it in the same directory not > only simplifies things from a project structure perspective, but also makes it > easier to refactor out common parts incrementally. > An added benefit is that this simplifies modular compilation, where for example > one would like a build of WebRTC without the H264 codec-specific parts. > > BUG=webrtc:6338 > > Committed: https://crrev.com/cc6817e9ce4a5ffc73efb660cf0368afbc7d9a4f > Cr-Commit-Position: refs/heads/master@{#14684} TBR=magjed@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6338 Committed: https://crrev.com/f04f14e772f803de39f8a6128e5157127cd35103 Cr-Commit-Position: refs/heads/master@{#14685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -420 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D webrtc/common_video/h264/h264_bitstream_parser.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/common_video/h264/h264_bitstream_parser.cc View 1 chunk +0 lines, -293 lines 0 comments Download
D webrtc/common_video/h264/h264_bitstream_parser_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/video_coding/utility/h264_bitstream_parser.h View 1 chunk +59 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/utility/h264_bitstream_parser.cc View 1 chunk +293 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kthelgason
Created Revert of Move bitstream parser to more appropriate directory.
4 years, 2 months ago (2016-10-19 17:34:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430353004/1
4 years, 2 months ago (2016-10-19 17:34:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 17:34:37 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f04f14e772f803de39f8a6128e5157127cd35103 Cr-Commit-Position: refs/heads/master@{#14685}
4 years, 2 months ago (2016-10-19 17:55:11 UTC) #7
kthelgason
4 years, 2 months ago (2016-10-19 17:58:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2434043002/ by kthelgason@webrtc.org.

The reason for reverting is: Internal project has been fixed.

Powered by Google App Engine
This is Rietveld 408576698