Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2430133005: Increase maximum probing bitrate to 100Mbps. (Closed)

Created:
4 years, 2 months ago by Sergey Ulanov
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cap probing bitrate by the max bitrate instead of hardcoded 10Mbps. Previously probing bitrate was capped at 10Mbps, which is too low for some application. Now ProbeContoller limits max probing rate to max allowed bitrate, which can be specified by the application. BUG=webrtc:6332 Committed: https://crrev.com/07c147d25da77a1d966387c0f9257cfcda5b0a9f Cr-Commit-Position: refs/heads/master@{#14927}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : handle max_bitrate_bps = 0 #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M webrtc/modules/congestion_controller/probe_controller.cc View 1 2 3 3 chunks +13 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller_unittest.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Sergey Ulanov
4 years, 2 months ago (2016-10-19 23:55:16 UTC) #2
Sergey Ulanov
ping
4 years, 1 month ago (2016-10-24 17:29:02 UTC) #3
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-31 12:01:31 UTC) #5
Sergey Ulanov
PTAL: I found that max_bitrate_bps is set to 0 when the application doesn't specify max ...
4 years, 1 month ago (2016-10-31 17:50:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430133005/40001
4 years, 1 month ago (2016-11-03 17:14:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/6984)
4 years, 1 month ago (2016-11-03 17:19:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2430133005/60001
4 years, 1 month ago (2016-11-03 18:27:33 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-03 18:59:52 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 19:14:34 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/07c147d25da77a1d966387c0f9257cfcda5b0a9f
Cr-Commit-Position: refs/heads/master@{#14927}

Powered by Google App Engine
This is Rietveld 408576698