Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2429803002: Prepare for introduction of rtc::PacketTransportInterface. (Closed)

Created:
4 years, 2 months ago by johan
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prepare for introduction of rtc::PacketTransportInterface. A rtc::PacketTransportInterface typedef is introduced to allow preparing downstream projects for the upcoming refactoring of cricket::Transport. This refactoring will introduce rtc::PacketTransportInterface in https://codereview.webrtc.org/2416023002/ . BUG=webrtc:6531 Committed: https://crrev.com/a9c7cfac41d48bf7a15dfb6c346f6c3809eb2722 Cr-Commit-Position: refs/heads/master@{#14672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M webrtc/p2p/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/p2p/base/packettransportinterface.h View 1 chunk +9 lines, -10 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
johan
4 years, 2 months ago (2016-10-18 10:50:53 UTC) #2
Taylor Brandstetter
lgtm. By the way, s/upcomming/upcoming in the CL description. Also, it may be useful to ...
4 years, 2 months ago (2016-10-18 17:51:25 UTC) #3
johan
On 2016/10/18 17:51:25, Taylor Brandstetter wrote: > lgtm. By the way, s/upcomming/upcoming in the CL ...
4 years, 2 months ago (2016-10-18 21:25:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2429803002/1
4 years, 2 months ago (2016-10-18 21:25:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 22:38:41 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 22:38:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9c7cfac41d48bf7a15dfb6c346f6c3809eb2722
Cr-Commit-Position: refs/heads/master@{#14672}

Powered by Google App Engine
This is Rietveld 408576698