Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: webrtc/voice_engine/channel.cc

Issue 2429503002: Simplifying audio network adaptor by moving receiver frame length range to ctor. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/channel.cc
diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc
index ac424305b7627a5bceda8f69d7a967db87f2db3a..975241ed9a649a15bbcafdca9faf40d839fd0997 100644
--- a/webrtc/voice_engine/channel.cc
+++ b/webrtc/voice_engine/channel.cc
@@ -1508,12 +1508,15 @@ int Channel::GetOpusDtx(bool* enabled) {
return success;
}
-bool Channel::EnableAudioNetworkAdaptor(const std::string& config_string) {
+bool Channel::EnableAudioNetworkAdaptor(const std::string& config_string,
+ int min_receiver_frame_length_ms,
+ int max_receiver_frame_length_ms) {
bool success = false;
audio_coding_->ModifyEncoder([&](std::unique_ptr<AudioEncoder>* encoder) {
if (*encoder) {
success = (*encoder)->EnableAudioNetworkAdaptor(
- config_string, Clock::GetRealTimeClock());
+ config_string, min_receiver_frame_length_ms,
+ max_receiver_frame_length_ms, Clock::GetRealTimeClock());
}
});
return success;
@@ -1526,16 +1529,6 @@ void Channel::DisableAudioNetworkAdaptor() {
});
}
-void Channel::SetReceiverFrameLengthRange(int min_frame_length_ms,
- int max_frame_length_ms) {
- audio_coding_->ModifyEncoder([&](std::unique_ptr<AudioEncoder>* encoder) {
- if (*encoder) {
- (*encoder)->SetReceiverFrameLengthRange(min_frame_length_ms,
- max_frame_length_ms);
- }
- });
-}
-
int32_t Channel::RegisterExternalTransport(Transport* transport) {
WEBRTC_TRACE(kTraceInfo, kTraceVoice, VoEId(_instanceId, _channelId),
"Channel::RegisterExternalTransport()");

Powered by Google App Engine
This is Rietveld 408576698