Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

Issue 2429503002: Simplifying audio network adaptor by moving receiver frame length range to ctor. (Closed)
Patch Set: nicer solution Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h b/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
index d19710254d23bc3d997546d3ccaf74d4911d2684..bce7f8ff03d76e9aba131f9fb7c556164957cde0 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
@@ -52,8 +52,6 @@ class FrameLengthController final : public Controller {
void MakeDecision(const NetworkMetrics& metrics,
AudioNetworkAdaptor::EncoderRuntimeConfig* config) override;
- void SetConstraints(const Constraints& constraints) override;
-
private:
friend class FrameLengthControllerForTest;
@@ -65,9 +63,6 @@ class FrameLengthController final : public Controller {
int to_frame_length_ms;
};
- void SetReceiverFrameLengthRange(int min_frame_length_ms,
- int max_frame_length_ms);
-
bool FrameLengthIncreasingDecision(
const NetworkMetrics& metrics,
const AudioNetworkAdaptor::EncoderRuntimeConfig& config) const;
@@ -78,9 +73,7 @@ class FrameLengthController final : public Controller {
const Config config_;
- std::vector<int> run_time_frame_lengths_ms_;
-
- std::vector<int>::iterator frame_length_ms_;
+ std::vector<int>::const_iterator frame_length_ms_;
std::map<FrameLengthChange, int> frame_length_change_criteria_;

Powered by Google App Engine
This is Rietveld 408576698