webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc - Issue 2429503002: Simplifying audio network adaptor by moving receiver frame length range to ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

Issue 2429503002: Simplifying audio network adaptor by moving receiver frame length range to ctor. (Closed)

Patch Set: nicer solution Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

index d4aeadc185047e22cf9fb11e20268e815cf6cbf0..c7700fd90623518e2691c1570e9dfed840f22698 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

@@ -139,17 +139,6 @@ TEST(AudioNetworkAdaptorImplTest,

states.audio_network_adaptor->GetEncoderRuntimeConfig();

}

-TEST(AudioNetworkAdaptorImplTest, SetConstraintsIsCalledOnSetFrameLengthRange) {

- auto states = CreateAudioNetworkAdaptor();

- for (auto& mock_controller : states.mock_controllers) {

- EXPECT_CALL(*mock_controller,

- SetConstraints(ConstraintsReceiverFrameLengthRangeIs(

- Controller::Constraints::FrameLengthRange(20, 120))));

- }

- states.audio_network_adaptor->SetReceiverFrameLengthRange(20, 120);

TEST(AudioNetworkAdaptorImplTest,

DumpEncoderRuntimeConfigIsCalledOnGetEncoderRuntimeConfig) {

auto states = CreateAudioNetworkAdaptor();