Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: webrtc/modules/audio_coding/audio_network_adaptor/controller.h

Issue 2429503002: Simplifying audio network adaptor by moving receiver frame length range to ctor. (Closed)
Patch Set: nicer solution Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_H_
12 #define WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_H_ 12 #define WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_H_
13 13
14 #include "webrtc/base/optional.h" 14 #include "webrtc/base/optional.h"
15 #include "webrtc/modules/audio_coding/audio_network_adaptor/include/audio_networ k_adaptor.h" 15 #include "webrtc/modules/audio_coding/audio_network_adaptor/include/audio_networ k_adaptor.h"
16 16
17 namespace webrtc { 17 namespace webrtc {
18 18
19 class Controller { 19 class Controller {
20 public: 20 public:
21 struct NetworkMetrics { 21 struct NetworkMetrics {
22 NetworkMetrics(); 22 NetworkMetrics();
23 ~NetworkMetrics(); 23 ~NetworkMetrics();
24 rtc::Optional<int> uplink_bandwidth_bps; 24 rtc::Optional<int> uplink_bandwidth_bps;
25 rtc::Optional<float> uplink_packet_loss_fraction; 25 rtc::Optional<float> uplink_packet_loss_fraction;
26 rtc::Optional<int> target_audio_bitrate_bps; 26 rtc::Optional<int> target_audio_bitrate_bps;
27 rtc::Optional<int> rtt_ms; 27 rtc::Optional<int> rtt_ms;
28 }; 28 };
29 29
30 struct Constraints {
31 Constraints();
32 ~Constraints();
33 struct FrameLengthRange {
34 FrameLengthRange(int min_frame_length_ms, int max_frame_length_ms);
35 ~FrameLengthRange();
36 int min_frame_length_ms;
37 int max_frame_length_ms;
38 };
39 rtc::Optional<FrameLengthRange> receiver_frame_length_range;
40 };
41
42 virtual ~Controller() = default; 30 virtual ~Controller() = default;
43 31
44 virtual void MakeDecision( 32 virtual void MakeDecision(
45 const NetworkMetrics& metrics, 33 const NetworkMetrics& metrics,
46 AudioNetworkAdaptor::EncoderRuntimeConfig* config) = 0; 34 AudioNetworkAdaptor::EncoderRuntimeConfig* config) = 0;
47
48 virtual void SetConstraints(const Constraints& constraints);
49 }; 35 };
50 36
51 } // namespace webrtc 37 } // namespace webrtc
52 38
53 #endif // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_H_ 39 #endif // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698