Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: git_cl.py

Issue 2428383010: git cl try: Remove --name option, stop sending "reason" property. (Closed)
Patch Set: Remove reason option Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 09132a1b5be5a61cff2c5e03af977066cd640a7d..27dd8b4ed76b0240f40e2561e72a32b101a40ee6 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -509,7 +509,6 @@ def _trigger_try_jobs(auth_config, changelist, buckets, options,
'patch_project': project,
'patch_storage': 'rietveld',
'patchset': patchset,
- 'reason': options.name,
'rietveld': codereview_url,
},
}
@@ -4844,9 +4843,6 @@ def CMDtry(parser, args):
'json if decodable, or as string otherwise. '
'NOTE: using this may make your try job not usable for CQ, '
'which will then schedule another try job with default properties')
- # TODO(tandrii): if this even used?
- group.add_option(
- '-n', '--name', help='Try job name; default to current branch name')
group.add_option(
'--buildbucket-host', default='cr-buildbucket.appspot.com',
help='Host of buildbucket. The default host is %default.')
@@ -4877,9 +4873,6 @@ def CMDtry(parser, args):
if error_message:
parser.error('Can\'t trigger try jobs: %s' % error_message)
- if not options.name:
- options.name = cl.GetBranch()
-
if options.bucket and options.master:
parser.error('Only one of --bucket and --master may be used.')
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698