Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 2427733002: Revert of Add path for recovered packets from internal::Call to RtpStreamReceiver. (Closed)

Created:
4 years, 2 months ago by honghaiz3
Modified:
4 years, 2 months ago
Reviewers:
brandtr, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add path for recovered packets from internal::Call to RtpStreamReceiver. (patchset #2 id:60001 of https://codereview.webrtc.org/2390823009/ ) Reason for revert: Speculative revert as it may be the cause of the DrMemory test failure: https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/5115 Original issue's description: > Add path for recovered packets from internal::Call to RtpStreamReceiver. > > When the FlexfecReceiver recovers media packets, it inserts these into > internal::Call, which then distributes them to the appropriate > VideoReceiveStream/RtpStreamReceiver. > > BUG=webrtc:5654 > > Committed: https://crrev.com/9c4b4b47f4325b48e1856566a30983f9e4e30dd0 > Cr-Commit-Position: refs/heads/master@{#14642} TBR=stefan@webrtc.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5654 Committed: https://crrev.com/862d74d0176fa762b3c96cf20bd36f27e7001a47 Cr-Commit-Position: refs/heads/master@{#14652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M webrtc/call/call.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
honghaiz3
Created Revert of Add path for recovered packets from internal::Call to RtpStreamReceiver.
4 years, 2 months ago (2016-10-17 16:42:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2427733002/1
4 years, 2 months ago (2016-10-17 16:42:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 16:42:35 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/862d74d0176fa762b3c96cf20bd36f27e7001a47 Cr-Commit-Position: refs/heads/master@{#14652}
4 years, 2 months ago (2016-10-17 16:42:42 UTC) #7
brandtr
4 years, 2 months ago (2016-10-19 05:49:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2428303004/ by brandtr@webrtc.org.

The reason for reverting is: Flaky test has been fixed..

Powered by Google App Engine
This is Rietveld 408576698