Moved the AEC render sample queue into the audio processing module

Several subcomponents inside APM copy render audio from
the render side to the capture side using the same
pattern. Currently this is done independently for the
submodules.

This CL moves the the AEC functionality for this into
APM.

BUG=webrtc:5298, webrtc:6540
Committed: https://crrev.com/764e364933da2a6ba1629b066d0a897cd5e5c10c
Cr-Commit-Position: refs/heads/master@{#14726}

[peah-webrtc, 2016-10-17 12:55:46]

Description was changed from

==========
Moved the AEC render sample queue into the audio processing module

BUG=
==========

to

==========
Several subcomponents inside APM copy render audio from
the render side to the capture side using the same
pattern. Currently this is done independently for the 
submodules.

This CL moves the the AEC functionality for this into
APM.

BUG=webrtc:5298, webrtc:6540
==========

[peah-webrtc, 2016-10-17 12:59:02]

peah@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[ivoc, 2016-10-17 14:11:36]

Nice change! LGTM with some small nits.

https://codereview.webrtc.org/2427553003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2427553003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:774:
RTC_DCHECK_GE(160u, audio->num_frames_per_band());
I think this should actually be RTC_DCHECK_LE(audio->num_frames_per_band(),
160u), to get nicer error messages when the DCHECK fails.

https://codereview.webrtc.org/2427553003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:789:
std::max<size_t>(static_cast<size_t>(1),
I think you can remove the <size_t> after std::max.

[peah-webrtc, 2016-10-19 05:19:44]

https://codereview.webrtc.org/2427553003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2427553003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:774:
RTC_DCHECK_GE(160u, audio->num_frames_per_band());
On 2016/10/17 14:11:36, ivoc wrote:
> I think this should actually be RTC_DCHECK_LE(audio->num_frames_per_band(),
> 160u), to get nicer error messages when the DCHECK fails.

That makes a lot of sense! But I think that currently in the code, the
convention is to write it like this. I have no idea why but I'll keep it like it
is for consistency.

https://codereview.webrtc.org/2427553003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:789:
std::max<size_t>(static_cast<size_t>(1),
On 2016/10/17 14:11:36, ivoc wrote:
> I think you can remove the <size_t> after std::max.

Done.

[peah-webrtc, 2016-10-19 05:19:48]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-10-19 05:19:48]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2427553003/#ps20001 (title:
"Changes in response to reviewer comments")

[commit-bot: I haz the power, 2016-10-19 05:19:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 05:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 05:29:09]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15277)

[peah-webrtc, 2016-10-22 11:39:55]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-10-22 11:39:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.chromium.org/2427553003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-22 11:39:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-22 12:04:33]

Description was changed from

==========
Several subcomponents inside APM copy render audio from
the render side to the capture side using the same
pattern. Currently this is done independently for the 
submodules.

This CL moves the the AEC functionality for this into
APM.

BUG=webrtc:5298, webrtc:6540
==========

to

==========
Several subcomponents inside APM copy render audio from
the render side to the capture side using the same
pattern. Currently this is done independently for the 
submodules.

This CL moves the the AEC functionality for this into
APM.

BUG=webrtc:5298, webrtc:6540
==========

[commit-bot: I haz the power, 2016-10-22 12:04:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-22 12:04:41]

Description was changed from

==========
Several subcomponents inside APM copy render audio from
the render side to the capture side using the same
pattern. Currently this is done independently for the 
submodules.

This CL moves the the AEC functionality for this into
APM.

BUG=webrtc:5298, webrtc:6540
==========

to

==========
Several subcomponents inside APM copy render audio from
the render side to the capture side using the same
pattern. Currently this is done independently for the
submodules.

This CL moves the the AEC functionality for this into
APM.

BUG=webrtc:5298, webrtc:6540

Committed: https://crrev.com/764e364933da2a6ba1629b066d0a897cd5e5c10c
Cr-Commit-Position: refs/heads/master@{#14726}
==========

[commit-bot: I haz the power, 2016-10-22 12:04:42]

Patchset 3 (id:??) landed as
https://crrev.com/764e364933da2a6ba1629b066d0a897cd5e5c10c
Cr-Commit-Position: refs/heads/master@{#14726}