Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2427413004:
Minor cleanup of rtc::BasicPacketSocketFactory implementation. (Closed)
|
Created:
4 years, 2 months ago by johan Modified:
4 years, 1 month ago Reviewers:
Taylor Brandstetter CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMinor cleanup of rtc::BasicPacketSocketFactory implementation.
Remove unnecessary rtc:: namespace prefixes. Add #include <string>.
BUG=None
Committed: https://crrev.com/57e13defc770af028f69275abc66cdef2e2e923b
Cr-Commit-Position: refs/heads/master@{#14777}
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== Minor cleanup of rtc::BasickPacketSocketFactory implementation. BUG= ========== to ========== Minor cleanup of rtc::BasickPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG= ==========
Description was changed from ========== Minor cleanup of rtc::BasickPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG= ========== to ========== Minor cleanup of rtc::BasickPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=webrtc:6570 ==========
johan@webrtc.org changed reviewers: + deadbeef@webrtc.org
lgtm. By the way, for small refactoring like this, it's acceptable to put "BUG=None". Though bugs are still helpful to track larger refactoring efforts.
Description was changed from ========== Minor cleanup of rtc::BasickPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=webrtc:6570 ========== to ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=webrtc:6570 ==========
The CQ bit was checked by johan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by johan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=webrtc:6570 ========== to ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=None ==========
The CQ bit was checked by johan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=None ========== to ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=None ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=None ========== to ========== Minor cleanup of rtc::BasicPacketSocketFactory implementation. Remove unnecessary rtc:: namespace prefixes. Add #include <string>. BUG=None Committed: https://crrev.com/57e13defc770af028f69275abc66cdef2e2e923b Cr-Commit-Position: refs/heads/master@{#14777} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/57e13defc770af028f69275abc66cdef2e2e923b Cr-Commit-Position: refs/heads/master@{#14777} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
