Moved transport.h from webrtc/ to webrtc/api, created build target and updated dependencies.

webrtc/api/BUILD.gn

 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 if (is_android) {
@@ skipping 10 matching lines @@
 rtc_source_set("call_api") {
   sources = [
     "call/audio_receive_stream.h",
     "call/audio_send_stream.h",
     "call/audio_sink.h",
     "call/audio_state.h",
   ]
 
   deps = [
     # TODO(kjellander): Add remaining dependencies when webrtc:4243 is done.
+    ":transport_api",
     "..:webrtc_common",
     "../base:rtc_base_approved",
     "../modules/audio_coding:audio_encoder_interface",
   ]
 }
 
 config("libjingle_peerconnection_warnings_config") {
   # GN orders flags on a target before flags from configs. The default config
   # adds these flags so to cancel them out they need to come from a config and
   # cannot be on the target directly.
@@ skipping 268 matching lines @@
     "stats/rtcstats.h",
     "stats/rtcstats_objects.h",
     "stats/rtcstatsreport.h",
   ]
 
   deps = [
     "../base:rtc_base_approved",
   ]
 }
 
+# GYP version: webrtc/api/api.gyp:transport_api
+rtc_source_set("transport_api") {

[ossu, 2016/10/17 14:05:44]

If transport.h is in api/call, shouldn't it be part of the call_api target
instead of being its own target?

[aleloi, 2016/10/17 14:21:56]

I'm not sure, but I think it shouldn't be merged with call_api.
webrtc::Transport is not tightly coupled with the other things in call. It's
used in quite a lot of other places, which do include anything else from call.
Also, I think that splitting up large build targets in small independent
submodules is generally a good thing: it generates less dependencies in the
future and simplifies modularization. WDYT?

[the sun, 2016/10/17 14:38:35]

I was about to agree with Oskar first, but looking through the rest of your CL I
think it should be a separate target - there's no reason for the rtp_rtcp module
to know about ALL of Call, when it just needs Transport.

[ossu, 2016/10/17 14:54:58]

Alright. Should the file still be in call/ then? Or directly under api?

+  sources = [
+    "call/transport.h",
+  ]
+}
+
 if (rtc_include_tests) {
   config("peerconnection_unittests_config") {
     # The warnings below are enabled by default. Since GN orders compiler flags
     # for a target before flags from configs, the only way to disable such
     # warnings is by having them in a separate config, loaded from the target.
     # TODO(kjellander): Make the code compile without disabling these flags.
     # See https://bugs.webrtc.org/3307.
     if (is_clang && is_win) {
       cflags = [
         # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6267
@@ skipping 136 matching lines @@
 
       shared_libraries = [ ":libjingle_peerconnection_so" ]
     }
 
     android_resources("libjingle_peerconnection_android_unittest_resources") {
       resource_dirs = [ "androidtests/res" ]
       custom_package = "org.webrtc"
     }
   }
 }