Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2426543002: Append second nack list in same compound rtcp packet (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Append second nack list in same compound rtcp packet instead of replace BUG=webrtc:6483 Committed: https://crrev.com/142f019d87ed7d1d94236fc01d3415a8dd8cafae Cr-Commit-Position: refs/heads/master@{#14708}

Patch Set 1 #

Patch Set 2 : restored case with two compound packets with nacks one after another #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -21 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 2 chunks +31 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
4 years, 2 months ago (2016-10-19 09:43:57 UTC) #2
åsapersson
lgtm
4 years, 2 months ago (2016-10-20 13:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2426543002/20001
4 years, 2 months ago (2016-10-20 13:25:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 15:22:45 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 15:39:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/142f019d87ed7d1d94236fc01d3415a8dd8cafae
Cr-Commit-Position: refs/heads/master@{#14708}

Powered by Google App Engine
This is Rietveld 408576698