Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2426473004: Add rtc::Optional::reset (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, ossu
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add rtc::Optional::reset BUG=None Committed: https://crrev.com/c4fd23cdda1fb6b8f1ac5f3105c864c22c3ce704 Cr-Commit-Position: refs/heads/master@{#14651}

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M webrtc/base/optional.h View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M webrtc/base/optional_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
Does it make sense to implement emplace too? or there is short-term plan to import ...
4 years, 2 months ago (2016-10-17 12:11:15 UTC) #2
kwiberg-webrtc
lgtm. And no, there's unfortunately no short-term plan to steal Chromium's Optional; it shouldn't be ...
4 years, 2 months ago (2016-10-17 12:21:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2426473004/40001
4 years, 2 months ago (2016-10-17 12:47:53 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 14:16:57 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 14:17:05 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4fd23cdda1fb6b8f1ac5f3105c864c22c3ce704
Cr-Commit-Position: refs/heads/master@{#14651}

Powered by Google App Engine
This is Rietveld 408576698