Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2426423005: BringSelectedWindowToFront should bring the window to front instead of only focusing it (Closed)

Created:
4 years, 2 months ago by Hzj_jie
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

BringSelectedWindowToFront should bring the window to front instead of only focusing it The API is misused, please refer to the bug for detail explanation. BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6565 Committed: https://crrev.com/bdb8df895a157bb3b9419c63c22ada41cfba641d Cr-Commit-Position: refs/heads/master@{#14715}

Patch Set 1 #

Patch Set 2 : != FALSE instead of == TRUE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Hzj_jie
4 years, 2 months ago (2016-10-20 00:59:31 UTC) #4
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-20 16:53:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2426423005/20001
4 years, 2 months ago (2016-10-20 18:16:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-20 20:16:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2426423005/40001
4 years, 2 months ago (2016-10-20 23:41:43 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-20 23:44:20 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 23:44:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdb8df895a157bb3b9419c63c22ada41cfba641d
Cr-Commit-Position: refs/heads/master@{#14715}

Powered by Google App Engine
This is Rietveld 408576698