Android: Move YuvConverter to its own file

Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file. It is also used outside of SurfaceTextureHelper.

BUG=webrtc:6470
R=sakal@webrtc.org

Committed: https://crrev.com/577bc1921096908f8e348e9730264e8bb1fab91e
Cr-Commit-Position: refs/heads/master@{#14683}

[magjed_webrtc, 2016-10-19 08:56:40]

Description was changed from

==========
Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file and is now used
outside SurfaceTextureHelper.

BUG=webrtc:6470
==========

to

==========
Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file. It is also used
outside of SurfaceTextureHelper.

BUG=webrtc:6470
==========

[magjed_webrtc, 2016-10-19 08:56:53]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-10-19 08:57:01]

Sami - please take a look.

[magjed_webrtc, 2016-10-19 09:32:50]

On 2016/10/19 08:57:01, magjed_webrtc wrote:
> Sami - please take a look.

Hold on reviewing this CL, I missed some stuff; I should move the YuvConverter
tests to a separate file as well.

[magjed_webrtc, 2016-10-19 09:59:57]

On 2016/10/19 09:32:50, magjed_webrtc wrote:
> On 2016/10/19 08:57:01, magjed_webrtc wrote:
> > Sami - please take a look.
> 
> Hold on reviewing this CL, I missed some stuff; I should move the YuvConverter
> tests to a separate file as well.

Nevermind, that test is actually a SurfaceTextureHelper test. I will add a new
pure YuvConverterTest in a follow-up CL.

So, please take a look.

[sakal, 2016-10-19 11:16:03]

I am trusting you didn't actually change anything in the code.

https://codereview.webrtc.org/2426023002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/YuvConverter.java (right):

https://codereview.webrtc.org/2426023002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/YuvConverter.java:21: public class
YuvConverter {
nit: Do we want to expose this class to external users?

[magjed_webrtc, 2016-10-19 12:27:01]

https://codereview.webrtc.org/2426023002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/YuvConverter.java (right):

https://codereview.webrtc.org/2426023002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/YuvConverter.java:21: public class
YuvConverter {
On 2016/10/19 11:16:02, sakal wrote:
> nit: Do we want to expose this class to external users?

Ok, let's make it package private for now.

[sakal, 2016-10-19 13:06:35]

lgtm

[magjed_webrtc, 2016-10-19 13:08:21]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-10-19 13:08:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 13:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 13:09:43]

Try jobs failed on following builders:
  ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/11642)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/13967)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19201)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/17879)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/18592)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gyp_dbg/builds/1599)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19259)

[magjed_webrtc, 2016-10-19 13:29:16]

Description was changed from

==========
Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file. It is also used
outside of SurfaceTextureHelper.

BUG=webrtc:6470
==========

to

==========
Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file. It is also used
outside of SurfaceTextureHelper.

BUG=webrtc:6470
R=sakal@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/577bc1921096908f8e348e973...
==========

[magjed_webrtc, 2016-10-19 13:29:18]

Committed patchset #4 (id:60001) manually as
577bc1921096908f8e348e9730264e8bb1fab91e (presubmit successful).

[commit-bot: I haz the power, 2016-10-19 13:50:40]

Description was changed from

==========
Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file. It is also used
outside of SurfaceTextureHelper.

BUG=webrtc:6470
R=sakal@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/577bc1921096908f8e348e973...
==========

to

==========
Android: Move YuvConverter to its own file

YuvConverter is complex class that deserves its own file. It is also used
outside of SurfaceTextureHelper.

BUG=webrtc:6470
R=sakal@webrtc.org

Committed: https://crrev.com/577bc1921096908f8e348e9730264e8bb1fab91e
Cr-Commit-Position: refs/heads/master@{#14683}
==========