Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2426003002: Second try to get "Support for video file instead of camera and output video out to file" accepted (Closed)

Created:
4 years, 2 months ago by mandermo
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Second try to get "Support for video file instead of camera and output video out to file" accepted The old CL can be found here: https://codereview.webrtc.org/2273573003/ The orginal broke down stream, this CL tries to solve those issues. BUG=webrtc:6545 Committed: https://crrev.com/64e1a32e2f3fa790927e71c783520c2d1ed2ead1 Cr-Commit-Position: refs/heads/master@{#14665}

Patch Set 1 #

Patch Set 2 : Removal of the offending loggging line #

Messages

Total messages: 22 (10 generated)
mandermo
Fix for the broken downstream. The first patch is a revert of the revert. The ...
4 years, 2 months ago (2016-10-18 13:59:14 UTC) #2
kjellander_webrtc
lgtm assuming you've verified there are no more similar errors. Please refer to bug and ...
4 years, 2 months ago (2016-10-18 14:07:03 UTC) #4
phoglund
fix lgtm you need a rubberstamp from an appropriate owner, perhaps from the old review ...
4 years, 2 months ago (2016-10-18 14:18:02 UTC) #6
mandermo
Adding one more reviewer.
4 years, 2 months ago (2016-10-18 14:22:52 UTC) #8
sakal
I am trusting you didn't change anything else than remove the breaking line. lgtm
4 years, 2 months ago (2016-10-18 14:25:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2426003002/20001
4 years, 2 months ago (2016-10-18 14:52:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9274)
4 years, 2 months ago (2016-10-18 15:16:00 UTC) #13
mandermo
+magjed because he is needed, because he is owner of files.
4 years, 2 months ago (2016-10-18 15:33:46 UTC) #15
magjed_webrtc
lgtm. In the future, revert the revert instead of manually making a new CL. The ...
4 years, 2 months ago (2016-10-18 15:38:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2426003002/20001
4 years, 2 months ago (2016-10-18 15:39:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 15:47:56 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 15:48:06 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64e1a32e2f3fa790927e71c783520c2d1ed2ead1
Cr-Commit-Position: refs/heads/master@{#14665}

Powered by Google App Engine
This is Rietveld 408576698