Fix for the broken downstream. The first patch is a revert of the revert. The ...
4 years, 2 months ago
(2016-10-18 13:59:14 UTC)
#2
Fix for the broken downstream.
The first patch is a revert of the revert. The second patch removes the
offending logging line.
mandermo
Description was changed from ========== Second try get "Support for video file instead of camera ...
4 years, 2 months ago
(2016-10-18 14:06:59 UTC)
#3
Description was changed from
==========
Second try get "Support for video file instead of camera and output video out to
file" accepted
The orginal broke down stream, this CL tries to solve those issues.
==========
to
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The orginal broke down stream, this CL tries to solve those issues.
==========
kjellander_webrtc
lgtm assuming you've verified there are no more similar errors. Please refer to bug and ...
4 years, 2 months ago
(2016-10-18 14:07:03 UTC)
#4
lgtm assuming you've verified there are no more similar errors.
Please refer to bug and the old CL in the description
mandermo
Description was changed from ========== Second try to get "Support for video file instead of ...
4 years, 2 months ago
(2016-10-18 14:10:17 UTC)
#5
Description was changed from
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The orginal broke down stream, this CL tries to solve those issues.
==========
to
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The old CL can be found here: https://codereview.webrtc.org/2273573003/
The orginal broke down stream, this CL tries to solve those issues.
BUG=webrtc:6545
==========
phoglund
fix lgtm you need a rubberstamp from an appropriate owner, perhaps from the old review ...
4 years, 2 months ago
(2016-10-18 14:18:02 UTC)
#6
fix lgtm
you need a rubberstamp from an appropriate owner, perhaps from the old review if
one reviewer has enough privileges to approve everything.
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9274)
4 years, 2 months ago
(2016-10-18 15:16:00 UTC)
#13
+magjed because he is needed, because he is owner of files.
4 years, 2 months ago
(2016-10-18 15:33:46 UTC)
#15
+magjed because he is needed, because he is owner of files.
magjed_webrtc
lgtm. In the future, revert the revert instead of manually making a new CL. The ...
4 years, 2 months ago
(2016-10-18 15:38:19 UTC)
#16
lgtm. In the future, revert the revert instead of manually making a new CL. The
CL description will then be filled in for you with appropriate links and
comments.
mandermo
The CQ bit was checked by mandermo@webrtc.org
4 years, 2 months ago
(2016-10-18 15:39:26 UTC)
#17
Description was changed from ========== Second try to get "Support for video file instead of ...
4 years, 2 months ago
(2016-10-18 15:47:53 UTC)
#19
Message was sent while issue was closed.
Description was changed from
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The old CL can be found here: https://codereview.webrtc.org/2273573003/
The orginal broke down stream, this CL tries to solve those issues.
BUG=webrtc:6545
==========
to
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The old CL can be found here: https://codereview.webrtc.org/2273573003/
The orginal broke down stream, this CL tries to solve those issues.
BUG=webrtc:6545
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago
(2016-10-18 15:47:56 UTC)
#20
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Description was changed from ========== Second try to get "Support for video file instead of ...
4 years, 2 months ago
(2016-10-18 15:48:05 UTC)
#21
Message was sent while issue was closed.
Description was changed from
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The old CL can be found here: https://codereview.webrtc.org/2273573003/
The orginal broke down stream, this CL tries to solve those issues.
BUG=webrtc:6545
==========
to
==========
Second try to get "Support for video file instead of camera and output video out
to file" accepted
The old CL can be found here: https://codereview.webrtc.org/2273573003/
The orginal broke down stream, this CL tries to solve those issues.
BUG=webrtc:6545
Committed: https://crrev.com/64e1a32e2f3fa790927e71c783520c2d1ed2ead1
Cr-Commit-Position: refs/heads/master@{#14665}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/64e1a32e2f3fa790927e71c783520c2d1ed2ead1 Cr-Commit-Position: refs/heads/master@{#14665}
4 years, 2 months ago
(2016-10-18 15:48:06 UTC)
#22
Issue 2426003002: Second try to get "Support for video file instead of camera and output video out to file" accepted
(Closed)
Created 4 years, 2 months ago by mandermo
Modified 4 years, 2 months ago
Reviewers: kjellander_webrtc, phoglund, sakal, magjed_webrtc
Base URL:
Comments: 0