Change RefCountedObject to use perfect forwarding.

Change RefCountedObject to use perfect forwarding.
The main reason for doing this is to allow refcounted objects to accept rvalue references in ctor and be able to std::move ctor rvalue arguments.
Also, refcounted.h is now generated using pump.py instead of manually creating each ctor version.

BUG= none

Committed: https://crrev.com/0489e498ebef75e13b7d72e7470903d3bcae50b4
Cr-Commit-Position: refs/heads/master@{#14687}

[perkj_webrtc, 2016-10-18 07:28:10]

perkj@webrtc.org changed reviewers:
+ hbos@webrtc.org, tommi@webrtc.org

[perkj_webrtc, 2016-10-18 07:28:10]

Please? 
This is mainly done to make it possible  to fix  my comment in
https://codereview.chromium.org/2317063002/diff/200001/content/renderer/media...
hbos, would you mind to do the chrome part  some day once this is landed?

[tommi, 2016-10-18 15:57:58]

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump
File webrtc/base/refcount.h.pump (right):

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump#n...
webrtc/base/refcount.h.pump:25: class RefCountInterface {
Can we have this definition in a non-generated header file?

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest.cc
File webrtc/base/refcount_unittest.cc (right):

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
webrtc/base/refcount_unittest.cc:24: RTC_DISALLOW_COPY_AND_ASSIGN(A);
private

[hbos, 2016-10-18 17:50:04]

On 2016/10/18 07:28:10, perkj_webrtc wrote:
> Please? 
> This is mainly done to make it possible  to fix  my comment in
>
https://codereview.chromium.org/2317063002/diff/200001/content/renderer/media...
> hbos, would you mind to do the chrome part  some day once this is landed?

Yes

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest.cc
File webrtc/base/refcount_unittest.cc (right):

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
webrtc/base/refcount_unittest.cc:49: scoped_refptr<RefCountedObject<Aref>>
aref(new RefCountedObject<Aref>());
Can you add more tests to make sure a constructor works with all parameter
types?
by value
by reference
by rvalue reference
(And make sure that the expected copies happen/don't happen.)

And perhaps a test that has a constructor that takes all three types at the same
time to make sure the implementation works with combinations.

[perkj_webrtc, 2016-10-19 00:43:14]

ptal

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump
File webrtc/base/refcount.h.pump (right):

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump#n...
webrtc/base/refcount.h.pump:25: class RefCountInterface {
On 2016/10/18 15:57:58, tommi (webrtc) wrote:
> Can we have this definition in a non-generated header file?

Done.

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest.cc
File webrtc/base/refcount_unittest.cc (right):

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
webrtc/base/refcount_unittest.cc:24: RTC_DISALLOW_COPY_AND_ASSIGN(A);
On 2016/10/18 15:57:58, tommi (webrtc) wrote:
> private

Done.

https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
webrtc/base/refcount_unittest.cc:49: scoped_refptr<RefCountedObject<Aref>>
aref(new RefCountedObject<Aref>());
On 2016/10/18 17:50:04, hbos wrote:
> Can you add more tests to make sure a constructor works with all parameter
> types?
> by value
> by reference
> by rvalue reference
> (And make sure that the expected copies happen/don't happen.)
> 
> And perhaps a test that has a constructor that takes all three types at the
same
> time to make sure the implementation works with combinations.

done. Since we use pump we don't need to test all ctors. Also since we use
universal references I am not sure how much value the last test actually have
but to be complete...

[perkj_webrtc, 2016-10-19 03:13:24]

On 2016/10/19 00:43:14, perkj_webrtc wrote:
> ptal
> 
> https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump
> File webrtc/base/refcount.h.pump (right):
> 
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump#n...
> webrtc/base/refcount.h.pump:25: class RefCountInterface {
> On 2016/10/18 15:57:58, tommi (webrtc) wrote:
> > Can we have this definition in a non-generated header file?
> 
> Done.
> 
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest.cc
> File webrtc/base/refcount_unittest.cc (right):
> 
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
> webrtc/base/refcount_unittest.cc:24: RTC_DISALLOW_COPY_AND_ASSIGN(A);
> On 2016/10/18 15:57:58, tommi (webrtc) wrote:
> > private
> 
> Done.
> 
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
> webrtc/base/refcount_unittest.cc:49: scoped_refptr<RefCountedObject<Aref>>
> aref(new RefCountedObject<Aref>());
> On 2016/10/18 17:50:04, hbos wrote:
> > Can you add more tests to make sure a constructor works with all parameter
> > types?
> > by value
> > by reference
> > by rvalue reference
> > (And make sure that the expected copies happen/don't happen.)
> > 
> > And perhaps a test that has a constructor that takes all three types at the
> same
> > time to make sure the implementation works with combinations.
> 
> done. Since we use pump we don't need to test all ctors. Also since we use
> universal references I am not sure how much value the last test actually have
> but to be complete...

oops- forgot to add the new header file...

[perkj_webrtc, 2016-10-19 12:37:58]

On 2016/10/19 03:13:24, perkj_webrtc wrote:
> On 2016/10/19 00:43:14, perkj_webrtc wrote:
> > ptal
> > 
> > https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump
> > File webrtc/base/refcount.h.pump (right):
> > 
> >
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount.h.pump#n...
> > webrtc/base/refcount.h.pump:25: class RefCountInterface {
> > On 2016/10/18 15:57:58, tommi (webrtc) wrote:
> > > Can we have this definition in a non-generated header file?
> > 
> > Done.
> > 
> >
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest.cc
> > File webrtc/base/refcount_unittest.cc (right):
> > 
> >
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
> > webrtc/base/refcount_unittest.cc:24: RTC_DISALLOW_COPY_AND_ASSIGN(A);
> > On 2016/10/18 15:57:58, tommi (webrtc) wrote:
> > > private
> > 
> > Done.
> > 
> >
>
https://codereview.webrtc.org/2425683003/diff/1/webrtc/base/refcount_unittest...
> > webrtc/base/refcount_unittest.cc:49: scoped_refptr<RefCountedObject<Aref>>
> > aref(new RefCountedObject<Aref>());
> > On 2016/10/18 17:50:04, hbos wrote:
> > > Can you add more tests to make sure a constructor works with all parameter
> > > types?
> > > by value
> > > by reference
> > > by rvalue reference
> > > (And make sure that the expected copies happen/don't happen.)
> > > 
> > > And perhaps a test that has a constructor that takes all three types at
the
> > same
> > > time to make sure the implementation works with combinations.
> > 
> > done. Since we use pump we don't need to test all ctors. Also since we use
> > universal references I am not sure how much value the last test actually
have
> > but to be complete...
> 
> oops- forgot to add the new header file...

Fixed

[tommi, 2016-10-19 17:31:23]

lgtm

[perkj_webrtc, 2016-10-19 19:00:28]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-10-19 19:00:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2425683003/#ps60001 (title:
"video_frame_buffer.cc use memset in string.h")

[commit-bot: I haz the power, 2016-10-19 19:00:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 19:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 19:13:37]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[hbos, 2016-10-19 22:21:20]

lgtm

[perkj_webrtc, 2016-10-20 05:57:19]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-10-20 05:57:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
hbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2425683003/#ps80001 (title:
"git cl lint + screen_capturer_differ_wrapper.cc")

[commit-bot: I haz the power, 2016-10-20 05:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-20 07:24:05]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-20 07:24:12]

Description was changed from

==========
Change RefCountedObject to use perfect forwarding.
The main reason for doing this is to allow refcounted objects to accept rvalue
references in ctor and be able to std::move ctor rvalue arguments.
Also, refcounted.h is now generated using pump.py instead of manually creating
each ctor version.

BUG= none
==========

to

==========
Change RefCountedObject to use perfect forwarding.
The main reason for doing this is to allow refcounted objects to accept rvalue
references in ctor and be able to std::move ctor rvalue arguments.
Also, refcounted.h is now generated using pump.py instead of manually creating
each ctor version.

BUG= none

Committed: https://crrev.com/0489e498ebef75e13b7d72e7470903d3bcae50b4
Cr-Commit-Position: refs/heads/master@{#14687}
==========

[commit-bot: I haz the power, 2016-10-20 07:24:13]

Patchset 5 (id:??) landed as
https://crrev.com/0489e498ebef75e13b7d72e7470903d3bcae50b4
Cr-Commit-Position: refs/heads/master@{#14687}