Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webrtc/modules/audio_coding/neteq/comfort_noise.cc

Issue 2425223002: NetEq now works with packets as values, rather than pointers. (Closed)
Patch Set: Compare packets better in test. One more const. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/neteq/comfort_noise.cc
diff --git a/webrtc/modules/audio_coding/neteq/comfort_noise.cc b/webrtc/modules/audio_coding/neteq/comfort_noise.cc
index 504a0bcd4ca40029b9166a57ec1343e3a7f34b3f..9493d0a41c3a7e702fbb9e348524040aa8932d32 100644
--- a/webrtc/modules/audio_coding/neteq/comfort_noise.cc
+++ b/webrtc/modules/audio_coding/neteq/comfort_noise.cc
@@ -24,17 +24,14 @@ void ComfortNoise::Reset() {
first_call_ = true;
}
-int ComfortNoise::UpdateParameters(Packet* packet) {
- assert(packet); // Existence is verified by caller.
+int ComfortNoise::UpdateParameters(const Packet& packet) {
// Get comfort noise decoder.
- if (decoder_database_->SetActiveCngDecoder(packet->payload_type) != kOK) {
- delete packet;
+ if (decoder_database_->SetActiveCngDecoder(packet.payload_type) != kOK) {
return kUnknownPayloadType;
}
ComfortNoiseDecoder* cng_decoder = decoder_database_->GetActiveCngDecoder();
RTC_DCHECK(cng_decoder);
- cng_decoder->UpdateSid(packet->payload);
- delete packet;
+ cng_decoder->UpdateSid(packet.payload);
return kOK;
}
« no previous file with comments | « webrtc/modules/audio_coding/neteq/comfort_noise.h ('k') | webrtc/modules/audio_coding/neteq/decoder_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698