Implement framesDecoded stat in video receive ssrc stats.

Implement framesDecoded stat in video receive ssrc stats.

Implemented as defined by this pull request: https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
Committed: https://crrev.com/e5ba44eab19b65108a6114131659d4b983b6c78f
Cr-Commit-Position: refs/heads/master@{#14789}

[sakal, 2016-10-17 13:58:26]

Patchset #1 (id:1) has been deleted

[sakal, 2016-10-17 14:59:41]

Patchset #1 (id:20001) has been deleted

[sakal, 2016-10-17 15:04:00]

Description was changed from

==========
Implement framesDecoded stat in RTCInboundRTPStreamStats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

to

==========
Implement framesDecoded stat in RTCInboundRTPStreamStats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

[sakal, 2016-10-17 15:04:00]

sakal@webrtc.org changed reviewers:
+ hbos@webrtc.org, hta@webrtc.org, tommi@webrtc.org

[sakal, 2016-10-17 15:05:09]

PTAL

It seems receive_statistics_proxy.cc doesn't have any unittests so I didn't add
one for this this stat. If you deem it necessary, I can create a new unittest
file with a test for this stat.

[hbos, 2016-10-18 18:23:27]

On 2016/10/17 15:05:09, sakal wrote:
> PTAL
> 
> It seems receive_statistics_proxy.cc doesn't have any unittests so I didn't
add
> one for this this stat. If you deem it necessary, I can create a new unittest
> file with a test for this stat.

Can you add a receive_statistics_proxy.cc and a statscollector_unittest.cc test
for this stat?

[hbos, 2016-10-18 18:25:55]

On 2016/10/18 18:23:27, hbos wrote:
> On 2016/10/17 15:05:09, sakal wrote:
> > PTAL
> > 
> > It seems receive_statistics_proxy.cc doesn't have any unittests so I didn't
> add
> > one for this this stat. If you deem it necessary, I can create a new
unittest
> > file with a test for this stat.
> 
> Can you add a receive_statistics_proxy.cc and a statscollector_unittest.cc
test
> for this stat?

And what report x is this added to ("x.framesDecoded")? Channel-#?

[sakal, 2016-10-20 12:06:59]

Description was changed from

==========
Implement framesDecoded stat in RTCInboundRTPStreamStats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

to

==========
Implement framesDecoded stat in video receive ssrc stats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

[sakal, 2016-10-20 12:08:16]

Patchset #3 (id:80001) has been deleted

[sakal, 2016-10-20 12:08:35]

Added more unittests as requested. PTAL

[tommi, 2016-10-20 13:43:06]

lgtm

[hbos, 2016-10-20 14:48:04]

lgtm

[hbos, 2016-10-20 16:47:24]

https://codereview.webrtc.org/2423823003/diff/100001/webrtc/media/base/mediac...
File webrtc/media/base/mediachannel.h (right):

https://codereview.webrtc.org/2423823003/diff/100001/webrtc/media/base/mediac...
webrtc/media/base/mediachannel.h:729: int frames_decoded;
Should be uint32_t

https://codereview.webrtc.org/2423823003/diff/100001/webrtc/video_receive_str...
File webrtc/video_receive_stream.h (right):

https://codereview.webrtc.org/2423823003/diff/100001/webrtc/video_receive_str...
webrtc/video_receive_stream.h:68: int frames_decoded = 0;
Should be uint32_t

[sakal, 2016-10-21 08:43:06]

https://codereview.chromium.org/2423823003/diff/100001/webrtc/media/base/medi...
File webrtc/media/base/mediachannel.h (right):

https://codereview.chromium.org/2423823003/diff/100001/webrtc/media/base/medi...
webrtc/media/base/mediachannel.h:729: int frames_decoded;
On 2016/10/20 16:47:23, hbos wrote:
> Should be uint32_t

Done.

https://codereview.chromium.org/2423823003/diff/100001/webrtc/video_receive_s...
File webrtc/video_receive_stream.h (right):

https://codereview.chromium.org/2423823003/diff/100001/webrtc/video_receive_s...
webrtc/video_receive_stream.h:68: int frames_decoded = 0;
On 2016/10/20 16:47:23, hbos wrote:
> Should be uint32_t

Done.

[hta-webrtc, 2016-10-21 09:03:50]

lgtm

https://codereview.chromium.org/2423823003/diff/120001/webrtc/video/receive_s...
File webrtc/video/receive_statistics_proxy_unittest.cc (right):

https://codereview.chromium.org/2423823003/diff/120001/webrtc/video/receive_s...
webrtc/video/receive_statistics_proxy_unittest.cc:35: };
Can you add a TODO to increase test coverage of ReceiveStatisticsProxy?

It doesn't belong in this CL, but should not be forgotten.

[sakal, 2016-10-21 10:46:04]

Patchset #5 (id:140001) has been deleted

[sakal, 2016-10-21 10:47:21]

https://codereview.chromium.org/2423823003/diff/120001/webrtc/video/receive_s...
File webrtc/video/receive_statistics_proxy_unittest.cc (right):

https://codereview.chromium.org/2423823003/diff/120001/webrtc/video/receive_s...
webrtc/video/receive_statistics_proxy_unittest.cc:35: };
On 2016/10/21 09:03:49, hta-webrtc wrote:
> Can you add a TODO to increase test coverage of ReceiveStatisticsProxy?
> 
> It doesn't belong in this CL, but should not be forgotten.

Done.

[sakal, 2016-10-21 10:47:26]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-10-21 10:47:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
hbos@webrtc.org, hta@webrtc.org
Link to the patchset: https://codereview.chromium.org/2423823003/#ps160001
(title: "Add TODO to add unittesting for ReceiveStatisticsProxy.")

[commit-bot: I haz the power, 2016-10-21 10:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 10:47:36]

This CL has an open dependency (Issue 2421193003 Patch 100001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[sakal, 2016-10-24 09:19:44]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-10-24 09:19:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 09:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 09:36:44]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9465)

[sakal, 2016-10-26 07:34:59]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-10-26 07:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-10-26 07:42:21]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-10-26 07:42:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
hta@webrtc.org, hbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2423823003/#ps180001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-10-26 07:42:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-26 07:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 07:53:21]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9548)

[sakal, 2016-10-26 13:15:27]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-10-26 13:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
hta@webrtc.org, hbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2423823003/#ps200001 (title:
"Add #include <memory> to receive_statistics_proxy_unittest.cc.")

[commit-bot: I haz the power, 2016-10-26 13:15:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-26 14:09:27]

Description was changed from

==========
Implement framesDecoded stat in video receive ssrc stats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

to

==========
Implement framesDecoded stat in video receive ssrc stats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

[commit-bot: I haz the power, 2016-10-26 14:09:28]

Committed patchset #7 (id:200001)

[commit-bot: I haz the power, 2016-10-26 14:09:37]

Description was changed from

==========
Implement framesDecoded stat in video receive ssrc stats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541
==========

to

==========
Implement framesDecoded stat in video receive ssrc stats.

Implemented as defined by this pull request:
https://github.com/w3c/webrtc-stats/pull/70

BUG=webrtc:6541

Committed: https://crrev.com/e5ba44eab19b65108a6114131659d4b983b6c78f
Cr-Commit-Position: refs/heads/master@{#14789}
==========

[commit-bot: I haz the power, 2016-10-26 14:09:39]

Patchset 7 (id:??) landed as
https://crrev.com/e5ba44eab19b65108a6114131659d4b983b6c78f
Cr-Commit-Position: refs/heads/master@{#14789}