Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Issue 2422223002: Import build/config/clang/clang.gni in webrtc/base/BUILD.gn (Closed)

Created:
4 years, 2 months ago by ehmaldonado
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True NOPRESUBMIT=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander Committed: https://crrev.com/5c639895fb8c7aa33602e2621e6f606e68d27f92 Cr-Commit-Position: refs/heads/master@{#14653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
ehmaldonado_webrtc
4 years, 2 months ago (2016-10-17 16:47:22 UTC) #7
Nico
On 2016/10/17 16:47:22, ehmaldonado_webrtc wrote: Rs-lgtm I'm assuming you checked you could repro the error ...
4 years, 2 months ago (2016-10-17 17:06:24 UTC) #8
ehmaldonado_webrtc
On 2016/10/17 17:06:24, Nico (mostly afk until Oct 23) wrote: > On 2016/10/17 16:47:22, ehmaldonado_webrtc ...
4 years, 2 months ago (2016-10-17 17:31:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2422223002/1
4 years, 2 months ago (2016-10-17 17:38:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9231)
4 years, 2 months ago (2016-10-17 18:03:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2422223002/1
4 years, 2 months ago (2016-10-17 19:09:30 UTC) #16
Nico
Trying to TBR=kjellander to hopefully heal the bots
4 years, 2 months ago (2016-10-17 19:09:50 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9238)
4 years, 2 months ago (2016-10-17 19:21:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2422223002/1
4 years, 2 months ago (2016-10-17 19:28:40 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:28:47 UTC) #24
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c639895fb8c7aa33602e2621e6f606e68d27f92 Cr-Commit-Position: refs/heads/master@{#14653}
4 years, 2 months ago (2016-10-17 19:28:56 UTC) #26
kjellander_webrtc
lgtm seems like it's passing the generate build files step now: https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/5087
4 years, 2 months ago (2016-10-18 06:01:14 UTC) #27
kjellander_webrtc
4 years, 2 months ago (2016-10-18 06:22:58 UTC) #28
Message was sent while issue was closed.
On 2016/10/18 06:01:14, kjellander_webrtc wrote:
> lgtm
> seems like it's passing the generate build files step now:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/...

Notice, you accidentally created this with your google.com account (which is why
I had some trouble finding it)

Powered by Google App Engine
This is Rietveld 408576698