|
|
Created:
4 years, 2 months ago by ehmaldonado Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionImport build/config/clang/clang.gni in webrtc/base/BUILD.gn
Currently,
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/...
is broken because of
Writing """\
clang_use_chrome_plugins = false
is_asan = true
is_clang = true
is_component_build = true
is_debug = false
llvm_force_head_revision = true
symbol_level = 2
target_cpu = "x86"
v8_enable_verify_heap = true
""" to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn.
C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check
--runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps
-> returned 1
ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion.
data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ]
^--------------
"clang_base_path" is not currently in scope.
See //content/test/BUILD.gn:307:7: which caused the file to be included.
"//third_party/webrtc/base:rtc_base",
^-----------------
NOTRY=True
NOPRESUBMIT=True
R=kjellander@webrtc.org, thakis@chromium.org
BUG=chromium:497757
TBR=kjellander
Committed: https://crrev.com/5c639895fb8c7aa33602e2621e6f606e68d27f92
Cr-Commit-Position: refs/heads/master@{#14653}
Patch Set 1 #
Messages
Total messages: 28 (15 generated)
The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ==========
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ==========
The CQ bit was unchecked by ehmaldonado@webrtc.org
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ==========
On 2016/10/17 16:47:22, ehmaldonado_webrtc wrote: Rs-lgtm I'm assuming you checked you could repro the error without this change and that it's gone now :-)
On 2016/10/17 17:06:24, Nico (mostly afk until Oct 23) wrote: > On 2016/10/17 16:47:22, ehmaldonado_webrtc wrote: > > Rs-lgtm > > I'm assuming you checked you could repro the error without this change and that > it's gone now :-) I'm not sure how to repro right now. I don't have access to a windows machine right now.
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9231)
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Trying to TBR=kjellander to hopefully heal the bots
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9238)
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True NOPRESUBMIT=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True NOPRESUBMIT=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True NOPRESUBMIT=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True NOPRESUBMIT=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander ========== to ========== Import build/config/clang/clang.gni in webrtc/base/BUILD.gn Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- NOTRY=True NOPRESUBMIT=True R=kjellander@webrtc.org, thakis@chromium.org BUG=chromium:497757 TBR=kjellander Committed: https://crrev.com/5c639895fb8c7aa33602e2621e6f606e68d27f92 Cr-Commit-Position: refs/heads/master@{#14653} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5c639895fb8c7aa33602e2621e6f606e68d27f92 Cr-Commit-Position: refs/heads/master@{#14653}
Message was sent while issue was closed.
lgtm seems like it's passing the generate build files step now: https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/...
Message was sent while issue was closed.
On 2016/10/18 06:01:14, kjellander_webrtc wrote: > lgtm > seems like it's passing the generate build files step now: > https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... Notice, you accidentally created this with your google.com account (which is why I had some trouble finding it) |