Cleanup of voice_engine includes.

Cleanup of voice_engine includes.

I added a few missing dependencies to the GN target of voice_engine while doing other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True

Committed: https://crrev.com/9ae585de8db1041cb1903ba317c83f8f4da9d8e0
Cr-Commit-Position: refs/heads/master@{#14633}

[aleloi, 2016-10-13 13:38:21]

Description was changed from

==========
Cleanup of voice_engine includes.

I added a few missing includes to voice_engine while doing other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=???
==========

to

==========
Cleanup of voice_engine includes.

I added a few missing includes to voice_engine while doing other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True
==========

[aleloi, 2016-10-13 13:40:21]

Description was changed from

==========
Cleanup of voice_engine includes.

I added a few missing includes to voice_engine while doing other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True
==========

to

==========
Cleanup of voice_engine includes.

I added a few missing dependencies to the GN target of voice_engine while doing
other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True
==========

[aleloi, 2016-10-13 13:40:21]

aleloi@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[aleloi, 2016-10-13 13:41:10]

Sorry for keeping you busy, but it's a very small change!

[the sun, 2016-10-13 13:46:57]

lgtm

https://codereview.webrtc.org/2421483002/diff/1/webrtc/voice_engine/BUILD.gn
File webrtc/voice_engine/BUILD.gn (right):

https://codereview.webrtc.org/2421483002/diff/1/webrtc/voice_engine/BUILD.gn#...
webrtc/voice_engine/BUILD.gn:96:
"../modules/audio_coding:builtin_audio_decoder_factory",
I would think this includes the above interface - do both need to be in the deps
list?

https://codereview.webrtc.org/2421483002/diff/1/webrtc/voice_engine/voice_eng...
File webrtc/voice_engine/voice_engine.gyp (right):

https://codereview.webrtc.org/2421483002/diff/1/webrtc/voice_engine/voice_eng...
webrtc/voice_engine/voice_engine.gyp:28:
'<(webrtc_root)/modules/modules.gyp:builtin_audio_decoder_factory',
Same question

[aleloi, 2016-10-13 13:49:30]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-10-13 13:49:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-13 13:57:18]

Description was changed from

==========
Cleanup of voice_engine includes.

I added a few missing dependencies to the GN target of voice_engine while doing
other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True
==========

to

==========
Cleanup of voice_engine includes.

I added a few missing dependencies to the GN target of voice_engine while doing
other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True
==========

[commit-bot: I haz the power, 2016-10-13 13:57:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 13:57:27]

Description was changed from

==========
Cleanup of voice_engine includes.

I added a few missing dependencies to the GN target of voice_engine while doing
other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True
==========

to

==========
Cleanup of voice_engine includes.

I added a few missing dependencies to the GN target of voice_engine while doing
other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not
allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True

Committed: https://crrev.com/9ae585de8db1041cb1903ba317c83f8f4da9d8e0
Cr-Commit-Position: refs/heads/master@{#14633}
==========

[commit-bot: I haz the power, 2016-10-13 13:57:28]

Patchset 1 (id:??) landed as
https://crrev.com/9ae585de8db1041cb1903ba317c83f8f4da9d8e0
Cr-Commit-Position: refs/heads/master@{#14633}