Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2420583002: Revert of Android audio playout now supports non-call media streams (Closed)

Created:
4 years, 2 months ago by henrika_webrtc
Modified:
4 years, 2 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android audio playout now supports non-call media streams (patchset #3 id:10004 of https://codereview.webrtc.org/2411263003/ ) Reason for revert: There is a risk of ending up in a bad state due to race conditions with this patch. Tests in downstream clients have shown that it can happen that an output stream is opened up in MUSIC mode when it should not. Reverting since the new functionality added here is not worth the risk of breaking existing clients. Original issue's description: > Android audio playout now supports non-call media streams. > > The default (preferred) stream type for output audio is STREAM_VOICE_CALL since the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run in another mode than COMM mode, we now accept it and change the stream type to STREAM_MUSIC instead. It can e.g. be suitable for applications that does not record audio or if a call shall be casted to a Chromecast device. > > The solution is somewhat experimental. > > NOTRY=TRUE > > BUG=webrtc:4767 > > Committed: https://crrev.com/872f614111f436d15e29516ce19c3b63d25b8639 > Cr-Commit-Position: refs/heads/master@{#14613} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4767 Committed: https://crrev.com/722b0dc10817c6dda6c092fc566301545371d495 Cr-Commit-Position: refs/heads/master@{#14626}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
henrika_webrtc
Created Revert of Android audio playout now supports non-call media streams
4 years, 2 months ago (2016-10-13 08:12:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2420583002/1
4 years, 2 months ago (2016-10-13 08:12:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 08:12:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/722b0dc10817c6dda6c092fc566301545371d495 Cr-Commit-Position: refs/heads/master@{#14626}
4 years, 2 months ago (2016-10-13 08:12:45 UTC) #7
hlundin-webrtc
4 years, 2 months ago (2016-10-13 12:02:10 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698