Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2420573002: Revert of Remove tools dir from root webrtc target (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
charujain
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove tools dir from root webrtc target (patchset #1 id:1 of https://codereview.webrtc.org/2412353004/ ) Reason for revert: Seems to break our Android Swarming bots. Probably due to https://cs.chromium.org/chromium/src/testing/buildbot/gn_isolate_map.pyl?rcl=0&l=875 Error: /b/c/b/Android32__M_Nexus5X__dbg_/src/buildtools/linux64/gn gen //out/Debug --check --runtime-deps-list-file=/b/c/b/Android32__M_Nexus5X__dbg_/src/out/Debug/runtime_deps -> returned 1 ERROR The label "//webrtc/tools:tools_unittests(//build/toolchain/android:arm)" isn't a target. When reading the line: //webrtc/tools:tools_unittests from the --runtime-deps-list-file=/b/c/b/Android32__M_Nexus5X__dbg_/src/out/Debug/runtime_deps GN gen failed: 1 Original issue's description: > Remove tools dir from root webrtc target > > Removing it as we don't need it to build as part of webrtc target. > > BUG=webrtc:6412 > NOTRY=True > > Committed: https://crrev.com/163b1a2d0a0f8e822d8cd15f6385057bc7988ad1 > Cr-Commit-Position: refs/heads/master@{#14622} TBR=charujain@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6412 Committed: https://crrev.com/da3303fda018323895601611cf80d83d9024baa2 Cr-Commit-Position: refs/heads/master@{#14624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of Remove tools dir from root webrtc target
4 years, 2 months ago (2016-10-13 03:50:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2420573002/1
4 years, 2 months ago (2016-10-13 03:50:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 03:50:20 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 03:50:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da3303fda018323895601611cf80d83d9024baa2
Cr-Commit-Position: refs/heads/master@{#14624}

Powered by Google App Engine
This is Rietveld 408576698