RTCDataChannelStats added.

webrtc/api/rtcstatscollector.h

Index: webrtc/api/rtcstatscollector.h
diff --git a/webrtc/api/rtcstatscollector.h b/webrtc/api/rtcstatscollector.h
index 712f9e29494a8e813242580b769de974f1b41cef..410b3bec2f73768475679fe5315c090b72a3c9e5 100644
--- a/webrtc/api/rtcstatscollector.h
+++ b/webrtc/api/rtcstatscollector.h
@@ -14,6 +14,7 @@
 #include <memory>
 #include <vector>
 
+#include "webrtc/api/datachannelinterface.h"
 #include "webrtc/api/stats/rtcstats_objects.h"
 #include "webrtc/api/stats/rtcstatsreport.h"
 #include "webrtc/base/asyncinvoker.h"
@@ -85,6 +86,9 @@ class RTCStatsCollector : public virtual rtc::RefCountInterface {
   void ProduceCertificateStatsFromSSLCertificateAndChain_s(
       int64_t timestamp_us, const rtc::SSLCertificate& certificate,
       RTCStatsReport* report) const;
+  // Produces |RTCDataChannelStats|.
+  void ProduceDataChannelStats_s(
+      int64_t timestamp_us, RTCStatsReport* report) const;
   // Produces |RTCIceCandidatePairStats| and |RTCIceCandidateStats|.
   void ProduceIceCandidateAndPairStats_s(
       int64_t timestamp_us, const SessionStats& session_stats,
@@ -116,8 +120,10 @@ class RTCStatsCollector : public virtual rtc::RefCountInterface {
   rtc::scoped_refptr<const RTCStatsReport> cached_report_;
 };
 
-// Helper function, exposed for unittests.
+// Helper functions, exposed for unittests.
 const char* CandidateTypeToRTCIceCandidateType(const std::string& type);
+const char* DataStateToRTCDataChannelState(

[hta-webrtc, 2016/10/12 22:23:39]

mcasas told me that functions that are exposed for testing should always have
names ending in "ForTesting" - there's a presubmit tool that will flag usage of
such functions outside tests.

"Functions used only for testing should be restricted 
to test-only scenarios either by #ifdefing them 
appropriately (e.g. #if defined(UNIT_TEST)) or by 
naming them with a ForTesting suffix. The latter will 
be checked at presubmit time to ensure they're only 
called by test files."

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md

[hbos, 2016/10/17 17:33:16]

Cool. So they're helper functions used by the .cc file (not a test) that if not
for usage in test files would live in the .cc's anonymous namespace. Sounds like
the presubmit would not allowed these to be called ForTesting.

I moved them to anonymous namespace and made "ForTesting" versions invoking them
that are only used in unittests.

+    DataChannelInterface::DataState state);
 
 }  // namespace webrtc