Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

webrtc/video/end_to_end_tests.cc

Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 631f4d9cb7aa0518f2f21f03de84f659c6074428..e2fb3426a32ca7e0ad762770052acf500f1a06d6 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -2125,13 +2125,17 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
                       : nullptr),
           sender_call_(nullptr),
           receiver_call_(nullptr),
-          start_runtime_ms_(-1) {}
+          start_runtime_ms_(-1),
+          num_frames_received_(0) {}
 
    private:
-    void OnFrame(const VideoFrame& video_frame) override {}
+    void OnFrame(const VideoFrame& video_frame) override {
+      rtc::CritScope lock(&crit_);
+      ++num_frames_received_;
+    }
 
     Action OnSendRtp(const uint8_t* packet, size_t length) override {
-      if (MinMetricRunTimePassed())
+      if (MinMetricRunTimePassed() && MinNumberOfFramesReceived())
         observation_complete_.Set();
 
       return SEND_PACKET;
@@ -2147,6 +2151,12 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
       return elapsed_sec > metrics::kMinRunTimeInSeconds * 2;
     }
 
+    bool MinNumberOfFramesReceived() const {
+      const int kMinRequiredHistogramSamples = 200;
+      rtc::CritScope lock(&crit_);
+      return num_frames_received_ > kMinRequiredHistogramSamples * 2;

[sprang_webrtc, 2016/10/17 07:50:18]

Why the *2 ?

[åsapersson, 2016/10/17 18:03:41]

Updated the cl and added a comment, ptal.

+    }
+
     void ModifyVideoConfigs(
         VideoSendStream::Config* send_config,
         std::vector<VideoReceiveStream::Config>* receive_configs,
@@ -2196,6 +2206,7 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
       EXPECT_TRUE(Wait()) << "Timed out waiting for packet to be NACKed.";
     }
 
+    rtc::CriticalSection crit_;
     const bool use_rtx_;
     const bool use_red_;
     const bool screenshare_;
@@ -2203,6 +2214,7 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
     Call* sender_call_;
     Call* receiver_call_;
     int64_t start_runtime_ms_;
+    int num_frames_received_ GUARDED_BY(&crit_);
   } test(use_rtx, use_red, screenshare);
 
   metrics::Reset();