Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying histograms stats to reduce flakyness.

BUG=webrtc:6509
Committed: https://crrev.com/1394c7b5949660295fde39b82443b731e1bf3110
Cr-Commit-Position: refs/heads/master@{#14669}

[åsapersson, 2016-10-12 21:31:50]

Description was changed from

==========
Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying
histograms stats to reduce flakyness.

BUG=webrtc:6509
==========

to

==========
Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying
histograms stats to reduce flakyness.

BUG=webrtc:6509
==========

[åsapersson, 2016-10-12 21:31:50]

asapersson@webrtc.org changed reviewers:
+ sprang@webrtc.org

[åsapersson, 2016-10-17 03:01:35]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[sprang_webrtc, 2016-10-17 07:50:18]

https://codereview.webrtc.org/2420443002/diff/20001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2420443002/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:2157: return num_frames_received_ >
kMinRequiredHistogramSamples * 2;
Why the *2 ?

[åsapersson, 2016-10-17 18:01:13]

Patchset #3 (id:40001) has been deleted

[åsapersson, 2016-10-17 18:03:41]

https://codereview.webrtc.org/2420443002/diff/20001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2420443002/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:2157: return num_frames_received_ >
kMinRequiredHistogramSamples * 2;
On 2016/10/17 07:50:18, språng wrote:
> Why the *2 ?

Updated the cl and added a comment, ptal.

[sprang_webrtc, 2016-10-18 07:57:40]

lgtm
thanks!

[stefan-webrtc, 2016-10-18 17:39:35]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-10-18 17:39:35]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-10-18 17:39:35]

lgtm

[commit-bot: I haz the power, 2016-10-18 17:39:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-18 18:50:52]

Description was changed from

==========
Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying
histograms stats to reduce flakyness.

BUG=webrtc:6509
==========

to

==========
Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying
histograms stats to reduce flakyness.

BUG=webrtc:6509
==========

[commit-bot: I haz the power, 2016-10-18 18:50:53]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-18 18:51:02]

Description was changed from

==========
Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying
histograms stats to reduce flakyness.

BUG=webrtc:6509
==========

to

==========
Fix for flaky test: EndToEndTest.VerifyHistogramStatsWithRtx

Add a limit for minimum number of frames to be received before verifying
histograms stats to reduce flakyness.

BUG=webrtc:6509

Committed: https://crrev.com/1394c7b5949660295fde39b82443b731e1bf3110
Cr-Commit-Position: refs/heads/master@{#14669}
==========

[commit-bot: I haz the power, 2016-10-18 18:51:03]

Patchset 3 (id:??) landed as
https://crrev.com/1394c7b5949660295fde39b82443b731e1bf3110
Cr-Commit-Position: refs/heads/master@{#14669}