Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2418413002: Enable logging to console in DirectRTCClientTest. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable logging to console in DirectRTCClientTest. This CL enables printing Android log to stdout for the test. This makes debugging the flakiness of the test easier. BUG=webrtc:6475 R=magjed@webrtc.org Committed: https://crrev.com/7e76560c3566fe2565b710761261538050f66c37 Cr-Commit-Position: refs/heads/master@{#14649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-17 07:59:38 UTC) #1
magjed_webrtc
Please elaborate the purpose of this CL in the CL description.
4 years, 2 months ago (2016-10-17 08:13:05 UTC) #2
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-17 09:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2418413002/1
4 years, 2 months ago (2016-10-17 09:44:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 10:17:13 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 10:17:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e76560c3566fe2565b710761261538050f66c37
Cr-Commit-Position: refs/heads/master@{#14649}

Powered by Google App Engine
This is Rietveld 408576698