Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2798)

Unified Diff: build/config/android/internal_rules.gni

Issue 2416073003: Only list direct deps as java libraries
Patch Set: add c++_shared Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index f656ea6854a3aea061b680c6bad559bc2ce49831..b747433bb24f751fe247767aa6d841c10f8ea2ef 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -287,22 +287,19 @@ template("write_build_config") {
# Don't list shared_libraries_runtime_deps_file as an input in order to
# avoid having to depend on the runtime_deps target. See comment in
# rules.gni for why we do this.
- args += [
- "--shared-libraries-runtime-deps",
- rebase_path(invoker.shared_libraries_runtime_deps_file,
- root_build_dir),
- ]
+ _rebased_files = rebase_path(invoker.shared_libraries_runtime_deps_file,
agrieve 2016/10/26 19:46:18 nit: can you pluralize this: shared_libraries_runt
+ root_build_dir)
+ args += [ "--shared-libraries-runtime-deps=$_rebased_files" ]
}
if (defined(invoker.secondary_abi_shared_libraries_runtime_deps_file)) {
# Don't list secondary_abi_shared_libraries_runtime_deps_file as an
# input in order to avoid having to depend on the runtime_deps target.
# See comment in rules.gni for why we do this.
- args += [
- "--secondary-abi-shared-libraries-runtime-deps",
- rebase_path(invoker.secondary_abi_shared_libraries_runtime_deps_file,
- root_build_dir),
- ]
+ _secondary_abi_rebased_files = rebase_path(
+ invoker.secondary_abi_shared_libraries_runtime_deps_file,
+ root_build_dir)
+ args += [ "--secondary-abi-shared-libraries-runtime-deps=$_secondary_abi_rebased_files" ]
}
if (defined(invoker.proguard_enabled) && invoker.proguard_enabled) {

Powered by Google App Engine
This is Rietveld 408576698