Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2415943002: Revert of Add RtcpRttStats to AudioStream (Closed)

Created:
4 years, 2 months ago by sprang_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add RtcpRttStats to AudioStream (patchset #1 id:1 of https://codereview.webrtc.org/2402333002/ ) Reason for revert: Speculative revert. Intermittent memory access errors suspected to be caused by this cl. See for instance https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Light/builds/8018 UNADDRESSABLE ACCESS of freed memory: reading 0x0331d330-0x0331d334 4 byte(s) # 0 webrtc::voe::RtcpRttStatsProxy::LastProcessedRtt # 1 webrtc::ModuleRtpRtcpImpl::Process Original issue's description: > Add RtcpRttStats to AudioStream > > BUG=webrtc:6508 > > Committed: https://crrev.com/e0729c56d35acfaf9738fdb32c6508cd78eaf089 > Cr-Commit-Position: refs/heads/master@{#14595} TBR=stefan@webrtc.org,minyue@webrtc.org,solenberg@webrtc.org,michaelt@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6508 Committed: https://crrev.com/982bf89444442823dfff1df539ee0e97192c5186 Cr-Commit-Position: refs/heads/master@{#14631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -90 lines) Patch
M webrtc/audio/audio_send_stream.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 9 chunks +5 lines, -10 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h View 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 4 chunks +0 lines, -34 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sprang_webrtc
Created Revert of Add RtcpRttStats to AudioStream
4 years, 2 months ago (2016-10-13 12:45:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2415943002/1
4 years, 2 months ago (2016-10-13 12:45:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 13:23:14 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 13:23:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/982bf89444442823dfff1df539ee0e97192c5186
Cr-Commit-Position: refs/heads/master@{#14631}

Powered by Google App Engine
This is Rietveld 408576698