Testing of VideoFileRenderer with byte frames

webrtc/examples/androidtests/src/org/appspot/apprtc/test/VideoFileRendererTest.java

+/*
+ *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+package org.webrtc;
+
+import android.test.InstrumentationTestCase;
+import android.test.suitebuilder.annotation.SmallTest;
+
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.lang.Thread;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Random;
+
+public class VideoFileRendererTest extends InstrumentationTestCase {

[sakal, 2016/10/19 11:13:35]

Try to make it a Robolectric test if possible. File reading and egl stuff might
be problematic but please at least investigate.

[mandermo, 2016/10/19 16:38:43]

The problem that native code is called in VideoFileRenderer for scaling.

+  @SmallTest
+  public void testYuvRenderingToFile() throws InterruptedException, IOException {
+    EglBase eglBase = EglBase.create();
+    int outputWidth = 64;
+    int outputHeight = 64;
+    final String videoOutpath = "/sdcard/chromium_tests_root/testvideoout.y4m";
+    VideoFileRenderer videoFileRenderer =
+        new VideoFileRenderer(videoOutpath, outputWidth, outputHeight, eglBase.getEglBaseContext());
+
+    int inputWidth = 32;
+    int inputHeight = 32;
+    for (int frameIdx = 0; frameIdx < 4; frameIdx++) {
+      Random random = new Random(frameIdx * 42);
+      ByteBuffer[] yuvPlanes = new ByteBuffer[3];
+      int inputFrameSize = inputWidth * inputHeight * 3 / 2;
+      int[] planeSizes = {
+          inputWidth * inputWidth, inputWidth * inputHeight / 4, inputWidth * inputHeight / 4};
+      int[] yuvStrides = {inputWidth, inputWidth / 2, inputWidth / 2};
+      for (int i = 0; i < 3; i++) {
+        byte[] planeBytes = new byte[planeSizes[i]];
+        random.nextBytes(planeBytes);
+        ByteBuffer buffer = ByteBuffer.allocateDirect(inputFrameSize);
+        buffer.put(planeBytes);

[sakal, 2016/10/19 11:13:35]

nit: Seems there is some unnecessary double allocation here but since it is a
test it doesn't really matter.

[mandermo, 2016/10/19 16:38:43]

As you said, it doesn't matter.

+        yuvPlanes[i] = buffer;
+      }
+      VideoRenderer.I420Frame frame =
+          new VideoRenderer.I420Frame(inputWidth, inputHeight, 0, yuvStrides, yuvPlanes, 0);
+
+      videoFileRenderer.renderFrame(frame);
+    }
+    videoFileRenderer.release();
+
+    RandomAccessFile writtenFile = new RandomAccessFile(videoOutpath, "r");
+    StringBuilder builder = new StringBuilder();
+    Random verificationRandom = new Random(23423);
+    String expectedData = "A5CC23AF39B91850A58176866D597446A49A9BA2C29F65B87B";

[sakal, 2016/10/19 11:13:35]

I am assuming you ran this once and got this hash and now you are just verifying
it stays the same? I would prefer at least some human readable testing as well.
At least the headers should be easy to verify.

[mandermo, 2016/10/19 16:38:43]

Added some testing for the header now.

+    for (int i = 0; i < expectedData.length() / 2; i++) {
+      int pos = verificationRandom.nextInt((int) writtenFile.length());
+      writtenFile.seek(pos);
+      builder.append(String.format("%02X", writtenFile.readByte()));
+    }
+
+    assertEquals(expectedData, builder.toString());
+  }
+}