Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: webrtc/modules/congestion_controller/include/defines.h

Issue 2415543002: Set min BWE bitrate form 10kbps to 5kbps and centralize minimum bitrate. (Closed)
Patch Set: Response to comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/include/defines.h
diff --git a/webrtc/modules/audio_coding/neteq/packet.cc b/webrtc/modules/congestion_controller/include/defines.h
similarity index 60%
copy from webrtc/modules/audio_coding/neteq/packet.cc
copy to webrtc/modules/congestion_controller/include/defines.h
index 8a19fe4d5923d5e22a5b485600c6da0c5f3856ba..001b1e414eed9b5bb33dd0f8644b4e39b403877a 100644
--- a/webrtc/modules/audio_coding/neteq/packet.cc
+++ b/webrtc/modules/congestion_controller/include/defines.h
@@ -8,12 +8,13 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#include "webrtc/modules/audio_coding/neteq/packet.h"
+#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_DEFINES_H_
+#define WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_DEFINES_H_
namespace webrtc {
-
-Packet::Packet() = default;
-
-Packet::~Packet() = default;
-
+namespace congestion_controller {
+constexpr int kMinBitrateBps = 5000;
stefan-webrtc 2016/10/31 08:58:57 I think we should put this behind a field trial to
michaelt 2016/10/31 11:09:09 Sounds fine to me. I had to move the impl. of the
+} // namespace congestion_controller
} // namespace webrtc
+
+#endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_DEFINES_H_

Powered by Google App Engine
This is Rietveld 408576698