Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/modules/congestion_controller/include/congestion_controller.h

Issue 2415543002: Set min BWE bitrate form 10kbps to 5kbps and centralize minimum bitrate. (Closed)
Patch Set: Implemented GetMinBitrateBps as static function. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 // packet headers and is measured in bits per second. 47 // packet headers and is measured in bits per second.
48 class Observer { 48 class Observer {
49 public: 49 public:
50 virtual void OnNetworkChanged(uint32_t bitrate_bps, 50 virtual void OnNetworkChanged(uint32_t bitrate_bps,
51 uint8_t fraction_loss, // 0 - 255. 51 uint8_t fraction_loss, // 0 - 255.
52 int64_t rtt_ms) = 0; 52 int64_t rtt_ms) = 0;
53 53
54 protected: 54 protected:
55 virtual ~Observer() {} 55 virtual ~Observer() {}
56 }; 56 };
57
58 static int GetMinBitrateBps();
stefan-webrtc 2016/11/01 09:09:15 I find it slightly weird that we expose this in th
michaelt 2016/11/01 09:21:55 Moving the CongestionController related classes in
59
57 CongestionController(Clock* clock, 60 CongestionController(Clock* clock,
58 Observer* observer, 61 Observer* observer,
59 RemoteBitrateObserver* remote_bitrate_observer, 62 RemoteBitrateObserver* remote_bitrate_observer,
60 RtcEventLog* event_log); 63 RtcEventLog* event_log);
61 CongestionController(Clock* clock, 64 CongestionController(Clock* clock,
62 Observer* observer, 65 Observer* observer,
63 RemoteBitrateObserver* remote_bitrate_observer, 66 RemoteBitrateObserver* remote_bitrate_observer,
64 RtcEventLog* event_log, 67 RtcEventLog* event_log,
65 std::unique_ptr<PacketRouter> packet_router, 68 std::unique_ptr<PacketRouter> packet_router,
66 std::unique_ptr<PacedSender> pacer); 69 std::unique_ptr<PacedSender> pacer);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 uint8_t last_reported_fraction_loss_ GUARDED_BY(critsect_); 135 uint8_t last_reported_fraction_loss_ GUARDED_BY(critsect_);
133 int64_t last_reported_rtt_ GUARDED_BY(critsect_); 136 int64_t last_reported_rtt_ GUARDED_BY(critsect_);
134 NetworkState network_state_ GUARDED_BY(critsect_); 137 NetworkState network_state_ GUARDED_BY(critsect_);
135 138
136 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(CongestionController); 139 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(CongestionController);
137 }; 140 };
138 141
139 } // namespace webrtc 142 } // namespace webrtc
140 143
141 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_CONGESTION_CONTROLLER_H_ 144 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_CONGESTION_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698