Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: webrtc/modules/congestion_controller/congestion_controller_unittest.cc

Issue 2415543002: Set min BWE bitrate form 10kbps to 5kbps and centralize minimum bitrate. (Closed)
Patch Set: Implemented GetMinBitrateBps as static function. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 controller_->SignalNetworkState(kNetworkDown); 128 controller_->SignalNetworkState(kNetworkDown);
129 } 129 }
130 130
131 TEST_F(CongestionControllerTest, ResetBweAndBitrates) { 131 TEST_F(CongestionControllerTest, ResetBweAndBitrates) {
132 int new_bitrate = 200000; 132 int new_bitrate = 200000;
133 EXPECT_CALL(observer_, OnNetworkChanged(new_bitrate, _, _)); 133 EXPECT_CALL(observer_, OnNetworkChanged(new_bitrate, _, _));
134 EXPECT_CALL(*pacer_, SetEstimatedBitrate(new_bitrate)); 134 EXPECT_CALL(*pacer_, SetEstimatedBitrate(new_bitrate));
135 controller_->ResetBweAndBitrates(new_bitrate, -1, -1); 135 controller_->ResetBweAndBitrates(new_bitrate, -1, -1);
136 136
137 // If the bitrate is reset to -1, the new starting bitrate will be 137 // If the bitrate is reset to -1, the new starting bitrate will be
138 // the minimum default bitrate 10000bps. 138 // the minimum default bitrate kMinBitrateBps.
139 int min_default_bitrate = 10000; 139 EXPECT_CALL(observer_, OnNetworkChanged(
140 EXPECT_CALL(observer_, OnNetworkChanged(min_default_bitrate, _, _)); 140 CongestionController::GetMinBitrateBps(), _, _));
141 EXPECT_CALL(*pacer_, SetEstimatedBitrate(min_default_bitrate)); 141 EXPECT_CALL(*pacer_,
142 SetEstimatedBitrate(CongestionController::GetMinBitrateBps()));
142 controller_->ResetBweAndBitrates(-1, -1, -1); 143 controller_->ResetBweAndBitrates(-1, -1, -1);
143 } 144 }
144 145
145 TEST_F(CongestionControllerTest, 146 TEST_F(CongestionControllerTest,
146 SignalNetworkStateAndQueueIsFullAndEstimateChange) { 147 SignalNetworkStateAndQueueIsFullAndEstimateChange) {
147 // Send queue is full 148 // Send queue is full
148 EXPECT_CALL(*pacer_, ExpectedQueueTimeMs()) 149 EXPECT_CALL(*pacer_, ExpectedQueueTimeMs())
149 .WillRepeatedly(Return(PacedSender::kMaxQueueLengthMs + 1)); 150 .WillRepeatedly(Return(PacedSender::kMaxQueueLengthMs + 1));
150 EXPECT_CALL(observer_, OnNetworkChanged(0, _, _)); 151 EXPECT_CALL(observer_, OnNetworkChanged(0, _, _));
151 controller_->Process(); 152 controller_->Process();
(...skipping 30 matching lines...) Expand all
182 controller_->SignalNetworkState(kNetworkDown); 183 controller_->SignalNetworkState(kNetworkDown);
183 EXPECT_EQ(0, controller_->GetPacerQueuingDelayMs()); 184 EXPECT_EQ(0, controller_->GetPacerQueuingDelayMs());
184 185
185 // Network is up, pacer delay should be reported. 186 // Network is up, pacer delay should be reported.
186 controller_->SignalNetworkState(kNetworkUp); 187 controller_->SignalNetworkState(kNetworkUp);
187 EXPECT_EQ(kQueueTimeMs, controller_->GetPacerQueuingDelayMs()); 188 EXPECT_EQ(kQueueTimeMs, controller_->GetPacerQueuingDelayMs());
188 } 189 }
189 190
190 } // namespace test 191 } // namespace test
191 } // namespace webrtc 192 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698