Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2415403002: Introduced the new parameter setting scheme for activating the high-pass filter in APM (Closed)
Patch Set: Changes in response to reviewer comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 2c0f5546074d6b3c89c526bf229664c651175769..d3ae3e8a6a964a913e05a9cb45fa67504eb84e10 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -199,10 +199,9 @@ struct Intelligibility {
//
// AudioProcessing::Config config;
// config.level_controller.enabled = true;
+// config.high_pass_filter.enabled = true;
// apm->ApplyConfig(config)
//
-// apm->high_pass_filter()->Enable(true);
-//
// apm->echo_cancellation()->enable_drift_compensation(false);
// apm->echo_cancellation()->Enable(true);
//
@@ -265,6 +264,10 @@ class AudioProcessing {
bool enabled = true;
#endif
} residual_echo_detector;
+
+ struct HighPassFilter {
+ bool enabled = false;
+ } high_pass_filter;
};
// TODO(mgraczyk): Remove once all methods that use ChannelLayout are gone.
@@ -554,6 +557,7 @@ class AudioProcessing {
virtual EchoCancellation* echo_cancellation() const = 0;
virtual EchoControlMobile* echo_control_mobile() const = 0;
virtual GainControl* gain_control() const = 0;
+ // TODO(peah): Deprecate this API call.
virtual HighPassFilter* high_pass_filter() const = 0;
virtual LevelEstimator* level_estimator() const = 0;
virtual NoiseSuppression* noise_suppression() const = 0;
@@ -960,7 +964,7 @@ class GainControl {
protected:
virtual ~GainControl() {}
};
-
+// TODO(peah): Remove this interface.
// A filtering component which removes DC offset and low-frequency noise.
// Recommended to be enabled on the client-side.
class HighPassFilter {
@@ -968,7 +972,6 @@ class HighPassFilter {
virtual int Enable(bool enable) = 0;
virtual bool is_enabled() const = 0;
- protected:
virtual ~HighPassFilter() {}
};

Powered by Google App Engine
This is Rietveld 408576698