Chromium Code Reviews

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2415403002: Introduced the new parameter setting scheme for activating the high-pass filter in APM (Closed)
Patch Set: New approach for introducing the new parameter setting scheme Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 4f6166556acab033171b67b0f01b85fa58e81dc3..992735ca9983af5f748f846d097465e08cf84ca6 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -781,14 +781,6 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
}
}
- if (options.highpass_filter) {
- LOG(LS_INFO) << "High pass filter enabled? " << *options.highpass_filter;
- if (voep->EnableHighPassFilter(*options.highpass_filter) == -1) {
- LOG_RTCERR1(SetHighpassFilterStatus, *options.highpass_filter);
- return false;
- }
- }
-
if (options.stereo_swapping) {
LOG(LS_INFO) << "Stereo swapping enabled? " << *options.stereo_swapping;
voep->EnableStereoChannelSwapping(*options.stereo_swapping);
@@ -877,6 +869,12 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
}
}
+ LOG(LS_INFO) << "High pass filter: "
the sun 2016/10/26 09:06:43 If the AudioProcessing::Config has a ToString() me
peah-webrtc 2016/10/28 05:50:28 I totally agree! I remove this log line as well as
+ << (!!options.highpass_filter ? *options.highpass_filter : -1);
+ if (options.highpass_filter) {
+ apm_config.high_pass_filter.enabled = *options.highpass_filter;
+ }
+
// We check audioproc for the benefit of tests, since FakeWebRtcVoiceEngine
// returns NULL on audio_processing().
webrtc::AudioProcessing* audioproc = voe_wrapper_->base()->audio_processing();
« no previous file with comments | « no previous file | webrtc/modules/audio_processing/BUILD.gn » ('j') | webrtc/modules/audio_processing/audio_processing_impl.h » ('J')

Powered by Google App Engine