Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2414953002: Remove duplicate entry in webrtc .gn file exec_script_whitelist (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove duplicate entry in webrtc .gn file exec_script_whitelist In the file .gn exec_script_whitelist has 2 copies of "//webrtc/modules/video_render/BUILD.gn", This CL removes the duplicate BUG=webrtc:6527 TEST=try bots R=kjellander@webrtc.org Committed: https://crrev.com/614f68f11217c89a890737238d7ae4f473a22427 Cr-Commit-Position: refs/heads/master@{#14621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fbarchard1
4 years, 2 months ago (2016-10-13 00:42:05 UTC) #1
kjellander_webrtc
That's odd. Thanks for cleaning it up. lgtm
4 years, 2 months ago (2016-10-13 00:43:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2414953002/1
4 years, 2 months ago (2016-10-13 00:49:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 01:11:50 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 01:11:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/614f68f11217c89a890737238d7ae4f473a22427
Cr-Commit-Position: refs/heads/master@{#14621}

Powered by Google App Engine
This is Rietveld 408576698