Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2414913002:
Fix experiment name in BitrateControllerTest. (Closed)
|
Created:
4 years, 2 months ago by stefan-webrtc Modified:
4 years, 2 months ago Reviewers:
mflodman CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix experiment name in BitrateControllerTest.
TBR=mflodman@webrtc.org
BUG=webrtc:6519
Committed: https://crrev.com/db158f9b9e9731c23636f18b81e6a72745b1986a
Cr-Commit-Position: refs/heads/master@{#14620}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Fix experiment name in BitrateControllerTest. BUG=None ========== to ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=None ==========
stefan@webrtc.org changed reviewers: + mflodman@webrtc.org
The CQ bit was checked by stefan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Broke tests.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/11473) ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/1385) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/11495) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/13818) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/17727) mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/18464) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15169) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...) mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19130)
The CQ bit was checked by stefan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/11474) ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/1386) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/11496) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/13819) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/17728)
Description was changed from ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=None ========== to ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=webrtc:6519 ==========
Description was changed from ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=webrtc:6519 ========== to ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=webrtc:6519 Committed: https://chromium.googlesource.com/external/webrtc/+/db158f9b9e9731c23636f18b8... ==========
Message was sent while issue was closed.
Description was changed from ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=webrtc:6519 ========== to ========== Fix experiment name in BitrateControllerTest. TBR=mflodman@webrtc.org BUG=webrtc:6519 Committed: https://crrev.com/db158f9b9e9731c23636f18b81e6a72745b1986a Cr-Commit-Position: refs/heads/master@{#14620} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as db158f9b9e9731c23636f18b81e6a72745b1986a (presubmit successful).
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/db158f9b9e9731c23636f18b81e6a72745b1986a Cr-Commit-Position: refs/heads/master@{#14620}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
