Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2414613003: DataChannelInterface default impl of [messages/bytes]_[sent/received]. (Closed)

Created:
4 years, 2 months ago by hbos
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

DataChannelInterface default impl of [messages/bytes]_[sent/received]. The default implementations are provided as to not break Chromium mocks, as soon as we have done a successful roll they should be updated and the default implementations removed. TBR=hta@webrtc.org, deadbeef@webrtc.org NOTRY=True BUG=chromium:654927 Committed: https://crrev.com/75c8fb4b2c138b99f6bb7ffa6e2f415594116eed Cr-Commit-Position: refs/heads/master@{#14617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M webrtc/api/datachannelinterface.h View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2414613003/1
4 years, 2 months ago (2016-10-12 21:38:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 21:48:18 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:48:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75c8fb4b2c138b99f6bb7ffa6e2f415594116eed
Cr-Commit-Position: refs/heads/master@{#14617}

Powered by Google App Engine
This is Rietveld 408576698