Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2413523003: Set screenshare.enabled parameter to false when running video_loopback test. (Closed)

Created:
4 years, 2 months ago by åsapersson
Modified:
4 years, 2 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set screenshare.enabled parameter to false when running video_loopback test. BUG=none Committed: https://crrev.com/3ec3da6fc2568f8267984dce435073abffb9de56 Cr-Commit-Position: refs/heads/master@{#14606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/video/video_loopback.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
åsapersson
4 years, 2 months ago (2016-10-11 22:48:06 UTC) #3
mflodman
lgtm
4 years, 2 months ago (2016-10-11 22:54:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2413523003/1
4 years, 2 months ago (2016-10-11 22:54:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 23:20:36 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 23:20:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ec3da6fc2568f8267984dce435073abffb9de56
Cr-Commit-Position: refs/heads/master@{#14606}

Powered by Google App Engine
This is Rietveld 408576698