Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2412433003: Revert of Prune connections based on network name. (Closed)

Created:
4 years, 2 months ago by sprang_webrtc
Modified:
4 years, 2 months ago
Reviewers:
honghaiz3, skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Prune connections based on network name. (patchset #3 id:130001 of https://codereview.webrtc.org/2395243005/ ) Reason for revert: Breaks upstream code. Original issue's description: > Prune connections based on network name. > Previously we prune connections on the same network pointer. > So if an IPv6 and an IPv4 network are on the same network interface, IPv4 connection won't be pruned even if an IPv6 connection with higher priority becomes writable. > > With this change, as long as one connection becomes writable, all connections having lower priority with the same network name will be pruned. > > Also simplify the implementation. > > BUG=webrtc:6512 > > Committed: https://crrev.com/aae2784c1fab9d1510393dec15d76caa574e2da8 > Cr-Commit-Position: refs/heads/master@{#14593} TBR=skvlad@webrtc.org,honghaiz@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6512 Committed: https://crrev.com/716978d075a6528ae77a2cef61753c27499d830f Cr-Commit-Position: refs/heads/master@{#14601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -109 lines) Patch
M webrtc/p2p/base/fakeportallocator.h View 11 chunks +18 lines, -42 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 2 chunks +48 lines, -29 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 8 chunks +11 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sprang_webrtc
Created Revert of Prune connections based on network name.
4 years, 2 months ago (2016-10-11 13:43:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2412433003/1
4 years, 2 months ago (2016-10-11 13:43:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 13:43:31 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 13:43:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/716978d075a6528ae77a2cef61753c27499d830f
Cr-Commit-Position: refs/heads/master@{#14601}

Powered by Google App Engine
This is Rietveld 408576698