Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2412353004:
Remove tools dir from root webrtc target (Closed)
|
Created:
4 years, 2 months ago by charujain Modified:
4 years, 2 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove tools dir from root webrtc target
Removing it as we don't need it to build as part of webrtc target.
BUG=webrtc:6412
NOTRY=True
Committed: https://crrev.com/163b1a2d0a0f8e822d8cd15f6385057bc7988ad1
Cr-Commit-Position: refs/heads/master@{#14622}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Remove tools dir from root webrtc target Removing it as we dont need it to build as of webrtc target. BUG= ========== to ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as of webrtc target. BUG=webrtc:6412 ==========
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Description was changed from ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as of webrtc target. BUG=webrtc:6412 ========== to ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as of webrtc target. BUG=webrtc:6412 NOTRY=True ==========
Description was changed from ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as of webrtc target. BUG=webrtc:6412 NOTRY=True ========== to ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 ==========
Description was changed from ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 ========== to ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by kjellander@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 NOTRY=True ========== to ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 NOTRY=True ========== to ========== Remove tools dir from root webrtc target Removing it as we don't need it to build as part of webrtc target. BUG=webrtc:6412 NOTRY=True Committed: https://crrev.com/163b1a2d0a0f8e822d8cd15f6385057bc7988ad1 Cr-Commit-Position: refs/heads/master@{#14622} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/163b1a2d0a0f8e822d8cd15f6385057bc7988ad1 Cr-Commit-Position: refs/heads/master@{#14622}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2420573002/ by kjellander@webrtc.org. The reason for reverting is: Seems to break our Android Swarming bots. Probably due to https://cs.chromium.org/chromium/src/testing/buildbot/gn_isolate_map.pyl?rcl=... Error: /b/c/b/Android32__M_Nexus5X__dbg_/src/buildtools/linux64/gn gen //out/Debug --check --runtime-deps-list-file=/b/c/b/Android32__M_Nexus5X__dbg_/src/out/Debug/runtime_deps -> returned 1 ERROR The label "//webrtc/tools:tools_unittests(//build/toolchain/android:arm)" isn't a target. When reading the line: //webrtc/tools:tools_unittests from the --runtime-deps-list-file=/b/c/b/Android32__M_Nexus5X__dbg_/src/out/Debug/runtime_deps GN gen failed: 1. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
