Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2411673005: Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." (Closed)

Created:
4 years, 2 months ago by sprang_webrtc
Modified:
4 years, 2 months ago
Reviewers:
johan, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." (patchset #1 id:1 of https://codereview.webrtc.org/2402993002/ ) Reason for revert: Upstream fixes landed. Original issue's description: > Revert of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." (patchset #1 id:1 of https://codereview.webrtc.org/2361053003/ ) > > Reason for revert: > Breaks upstream code. > > Original issue's description: > > Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." > > > > Original commit https://codereview.webrtc.org/2256663002 > > was reverted by https://codereview.webrtc.org/2290963002 . > > > > BUG=webrtc:6299 > > TBR=pthatcher@webrtc.org > > > > Committed: https://crrev.com/fc9414ab513941028309d15a2baf711ef38f93a7 > > Cr-Commit-Position: refs/heads/master@{#14584} > > TBR=pthatcher@webrtc.org,johan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6299 > > Committed: https://crrev.com/57cb873707fbcc4864f0ee98129f73e7bef26c1a > Cr-Commit-Position: refs/heads/master@{#14586} TBR=pthatcher@webrtc.org,johan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6299 Committed: https://crrev.com/e7c338fed4dfbcd2174edfe9e99d3e9fa800602e Cr-Commit-Position: refs/heads/master@{#14602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M webrtc/api/peerconnection.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/api/peerconnection.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sprang_webrtc
Created Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState."
4 years, 2 months ago (2016-10-11 15:37:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2411673005/1
4 years, 2 months ago (2016-10-11 15:37:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 16:04:47 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:04:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7c338fed4dfbcd2174edfe9e99d3e9fa800602e
Cr-Commit-Position: refs/heads/master@{#14602}

Powered by Google App Engine
This is Rietveld 408576698