Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate.

webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 133 matching lines @@
 TEST(AudioEncoderOpusTest, ToggleDtx) {
   auto states = CreateCodec(2);
   // Enable DTX
   EXPECT_TRUE(states.encoder->SetDtx(true));
   // Verify that the mode is still kAudio.
   EXPECT_EQ(AudioEncoderOpus::kAudio, states.encoder->application());
   // Turn off DTX.
   EXPECT_TRUE(states.encoder->SetDtx(false));
 }
 
-TEST(AudioEncoderOpusTest, SetBitrate) {
+TEST(AudioEncoderOpusTest,
+     OnReceivedTargetAudioBitrateWithoutAudioNetworkAdaptor) {
   auto states = CreateCodec(1);
   // Constants are replicated from audio_states.encoderopus.cc.
   const int kMinBitrateBps = 500;
   const int kMaxBitrateBps = 512000;
   // Set a too low bitrate.
-  states.encoder->SetTargetBitrate(kMinBitrateBps - 1);
+  states.encoder->OnReceivedTargetAudioBitrate(kMinBitrateBps - 1);
   EXPECT_EQ(kMinBitrateBps, states.encoder->GetTargetBitrate());
   // Set a too high bitrate.
-  states.encoder->SetTargetBitrate(kMaxBitrateBps + 1);
+  states.encoder->OnReceivedTargetAudioBitrate(kMaxBitrateBps + 1);
   EXPECT_EQ(kMaxBitrateBps, states.encoder->GetTargetBitrate());
   // Set the minimum rate.
-  states.encoder->SetTargetBitrate(kMinBitrateBps);
+  states.encoder->OnReceivedTargetAudioBitrate(kMinBitrateBps);
   EXPECT_EQ(kMinBitrateBps, states.encoder->GetTargetBitrate());
   // Set the maximum rate.
-  states.encoder->SetTargetBitrate(kMaxBitrateBps);
+  states.encoder->OnReceivedTargetAudioBitrate(kMaxBitrateBps);
   EXPECT_EQ(kMaxBitrateBps, states.encoder->GetTargetBitrate());
   // Set rates from 1000 up to 32000 bps.
   for (int rate = 1000; rate <= 32000; rate += 1000) {
-    states.encoder->SetTargetBitrate(rate);
+    states.encoder->OnReceivedTargetAudioBitrate(rate);
     EXPECT_EQ(rate, states.encoder->GetTargetBitrate());
   }
 }
 
 namespace {
 
 // Returns a vector with the n evenly-spaced numbers a, a + (b - a)/(n - 1),
 // ..., b.
-std::vector<double> IntervalSteps(double a, double b, size_t n) {
+std::vector<float> IntervalSteps(float a, float b, size_t n) {
   RTC_DCHECK_GT(n, 1u);
-  const double step = (b - a) / (n - 1);
-  std::vector<double> points;
-  for (size_t i = 0; i < n; ++i)
+  const float step = (b - a) / (n - 1);
+  std::vector<float> points;
+  points.push_back(a);

[minyue-webrtc, 2016/11/10 16:45:30]

This is to avoid numerical errors like 0.0f becomes -0.0f.

[kwiberg-webrtc, 2016/11/11 10:25:41]

Acknowledged.

+  for (size_t i = 1; i < n - 1; ++i)
     points.push_back(a + i * step);
+  points.push_back(b);
   return points;
 }
 
 // Sets the packet loss rate to each number in the vector in turn, and verifies
 // that the loss rate as reported by the encoder is |expected_return| for all
 // of them.
-void TestSetPacketLossRate(AudioEncoderOpus* encoder,
-                           const std::vector<double>& losses,
-                           double expected_return) {
-  for (double loss : losses) {
-    encoder->SetProjectedPacketLossRate(loss);
-    EXPECT_DOUBLE_EQ(expected_return, encoder->packet_loss_rate());
+void TestSetPacketLossRate(AudioEncoderOpusStates* states,
+                           const std::vector<float>& losses,
+                           float expected_return) {
+  // |kSampleIntervalMs| is chosen to ease the calculation since
+  // 0.9999 ^ 184198 = 1e-8. Which minimizes the effect of
+  // PacketLossFractionSmoother used in AudioEncoderOpus.
+  constexpr int64_t kSampleIntervalMs = 184198;
+  for (float loss : losses) {
+    states->encoder->OnReceivedUplinkPacketLossFraction(loss);
+    states->simulated_clock->AdvanceTimeMilliseconds(kSampleIntervalMs);
+    EXPECT_FLOAT_EQ(expected_return, states->encoder->packet_loss_rate());
   }
 }
 
 }  // namespace
 
 TEST(AudioEncoderOpusTest, PacketLossRateOptimized) {
   auto states = CreateCodec(1);
-  auto I = [](double a, double b) { return IntervalSteps(a, b, 10); };
-  const double eps = 1e-15;
+  auto I = [](float a, float b) { return IntervalSteps(a, b, 10); };
+  constexpr float eps = 1e-8f;

[minyue-webrtc, 2016/11/10 16:45:30]

I changed this because

OnReceivedUplinkPacketLossFraction takes a float argument, instead of double as
the old API did.

The numerical precision has to be reduced.

[kwiberg-webrtc, 2016/11/11 10:25:40]

Acknowledged.

 
   // Note that the order of the following calls is critical.
 
   // clang-format off
-  TestSetPacketLossRate(states.encoder.get(), I(0.00      , 0.01 - eps), 0.00);
-  TestSetPacketLossRate(states.encoder.get(), I(0.01 + eps, 0.06 - eps), 0.01);
-  TestSetPacketLossRate(states.encoder.get(), I(0.06 + eps, 0.11 - eps), 0.05);
-  TestSetPacketLossRate(states.encoder.get(), I(0.11 + eps, 0.22 - eps), 0.10);
-  TestSetPacketLossRate(states.encoder.get(), I(0.22 + eps, 1.00      ), 0.20);
+  TestSetPacketLossRate(&states, I(0.00f      , 0.01f - eps), 0.00f);
+  TestSetPacketLossRate(&states, I(0.01f + eps, 0.06f - eps), 0.01f);
+  TestSetPacketLossRate(&states, I(0.06f + eps, 0.11f - eps), 0.05f);
+  TestSetPacketLossRate(&states, I(0.11f + eps, 0.22f - eps), 0.10f);
+  TestSetPacketLossRate(&states, I(0.22f + eps, 1.00f      ), 0.20f);
 
-  TestSetPacketLossRate(states.encoder.get(), I(1.00      , 0.18 + eps), 0.20);
-  TestSetPacketLossRate(states.encoder.get(), I(0.18 - eps, 0.09 + eps), 0.10);
-  TestSetPacketLossRate(states.encoder.get(), I(0.09 - eps, 0.04 + eps), 0.05);
-  TestSetPacketLossRate(states.encoder.get(), I(0.04 - eps, 0.01 + eps), 0.01);
-  TestSetPacketLossRate(states.encoder.get(), I(0.01 - eps, 0.00      ), 0.00);
+  TestSetPacketLossRate(&states, I(1.00f      , 0.18f + eps), 0.20f);
+  TestSetPacketLossRate(&states, I(0.18f - eps, 0.09f + eps), 0.10f);
+  TestSetPacketLossRate(&states, I(0.09f - eps, 0.04f + eps), 0.05f);
+  TestSetPacketLossRate(&states, I(0.04f - eps, 0.01f + eps), 0.01f);
+  TestSetPacketLossRate(&states, I(0.01f - eps, 0.00f      ), 0.00f);
   // clang-format on
 }
 
 TEST(AudioEncoderOpusTest, SetReceiverFrameLengthRange) {
   auto states = CreateCodec(2);
   // Before calling to |SetReceiverFrameLengthRange|,
   // |supported_frame_lengths_ms| should contain only the frame length being
   // used.
   using ::testing::ElementsAre;
   EXPECT_THAT(states.encoder->supported_frame_lengths_ms(),
@@ skipping 76 matching lines @@
 }
 
 TEST(AudioEncoderOpusTest,
      PacketLossFractionSmoothedOnSetUplinkPacketLossFraction) {
   auto states = CreateCodec(2);
 
   // The values are carefully chosen so that if no smoothing is made, the test
   // will fail.
   constexpr float kPacketLossFraction_1 = 0.02f;
   constexpr float kPacketLossFraction_2 = 0.198f;
-  // |kSecondSampleTimeMs| is chose to ease the calculation since
+  // |kSecondSampleTimeMs| is chosen to ease the calculation since
   // 0.9999 ^ 6931 = 0.5.
-  constexpr float kSecondSampleTimeMs = 6931;
+  constexpr int64_t kSecondSampleTimeMs = 6931;

[minyue-webrtc, 2016/11/10 16:45:30]

There was an error (float->int64_t) in old code. fixed here too.

[kwiberg-webrtc, 2016/11/11 10:25:41]

Acknowledged.

 
   // First time, no filtering.
   states.encoder->OnReceivedUplinkPacketLossFraction(kPacketLossFraction_1);
-  EXPECT_DOUBLE_EQ(0.01, states.encoder->packet_loss_rate());
+  EXPECT_FLOAT_EQ(0.01f, states.encoder->packet_loss_rate());
 
   states.simulated_clock->AdvanceTimeMilliseconds(kSecondSampleTimeMs);
   states.encoder->OnReceivedUplinkPacketLossFraction(kPacketLossFraction_2);
 
   // Now the output of packet loss fraction smoother should be
   // (0.02 + 0.198) / 2 = 0.109, which reach the threshold for the optimized
   // packet loss rate to increase to 0.05. If no smoothing has been made, the
   // optimized packet loss rate should have been increase to 0.1.
-  EXPECT_DOUBLE_EQ(0.05, states.encoder->packet_loss_rate());
+  EXPECT_FLOAT_EQ(0.05f, states.encoder->packet_loss_rate());
 }
 
 }  // namespace webrtc