Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: webrtc/modules/audio_mixer/BUILD.gn

Issue 2411313003: Split audio mixer into interface and implementation. (Closed)
Patch Set: visibility Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_mixer/BUILD.gn
diff --git a/webrtc/modules/audio_mixer/BUILD.gn b/webrtc/modules/audio_mixer/BUILD.gn
index 412b4d08f78a6e62665129eefb60ae1f04f893fa..0b676a03af7c8bcb58a58ebd22a41e629c3283ca 100644
--- a/webrtc/modules/audio_mixer/BUILD.gn
+++ b/webrtc/modules/audio_mixer/BUILD.gn
@@ -8,15 +8,14 @@
import("../../build/webrtc.gni")
-config("audio_conference_mixer_config") {
- include_dirs = [ "../../modules/include" ]
-}
-
-rtc_static_library("audio_mixer") {
+rtc_static_library("audio_mixer_impl") {
+ visibility = [
+ "../../modules/*",
the sun 2016/10/12 15:26:10 Does this mean it is visible to webrtc/modules/? W
aleloi 2016/10/12 15:36:02 The default visibility is that everything is visib
the sun 2016/10/13 07:55:00 Ah, I forgot about the unit test. It would be nice
+ "../../audio:audio",
+ ]
sources = [
"audio_frame_manipulator.cc",
"audio_frame_manipulator.h",
- "audio_mixer.h",
"audio_mixer_impl.cc",
"audio_mixer_impl.h",
"audio_source_with_mix_status.cc",
@@ -24,17 +23,15 @@ rtc_static_library("audio_mixer") {
]
public = [
- "audio_mixer.h",
+ "audio_mixer_impl.h",
]
- public_configs = [ ":audio_conference_mixer_config" ]
-
deps = [
"../..:webrtc_common",
+ "../../api:audio_mixer_api",
"../../base:rtc_base_approved",
"../../modules/audio_processing",
"../../modules/utility",
"../../system_wrappers",
- "../../voice_engine:level_indicator",
]
}

Powered by Google App Engine
This is Rietveld 408576698