Android audio playout now supports non-call media streams

Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run in another mode than COMM mode, we now accept it and change the stream type to STREAM_MUSIC instead. It can e.g. be suitable for applications that does not record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

NOTRY=TRUE

BUG=webrtc:4767
Committed: https://crrev.com/872f614111f436d15e29516ce19c3b63d25b8639
Cr-Commit-Position: refs/heads/master@{#14613}

[henrika_webrtc, 2016-10-12 12:20:23]

Description was changed from

==========
Android audio playout now supports non-call media streams

BUG=
==========

to

==========
Android audio playout now supports non-call media streams

BUG=webrtc:4767
==========

[henrika_webrtc, 2016-10-12 12:20:23]

henrika@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[henrika_webrtc, 2016-10-12 12:26:44]

Description was changed from

==========
Android audio playout now supports non-call media streams

BUG=webrtc:4767
==========

to

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the
WebRTC stack is mainly intended for VoIP calls. But if the user wants to run in
another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

BUG=webrtc:4767
==========

[henrika_webrtc, 2016-10-12 12:27:11]

Description was changed from

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the
WebRTC stack is mainly intended for VoIP calls. But if the user wants to run in
another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

BUG=webrtc:4767
==========

to

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

BUG=webrtc:4767
==========

[henrika_webrtc, 2016-10-12 12:28:05]

PTAL

[hlundin-webrtc, 2016-10-12 12:58:41]

LGTM with one nit.

https://codereview.webrtc.org/2411263003/diff/20001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java
(right):

https://codereview.webrtc.org/2411263003/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:197:
// e.g. be suitable for applications that does not record audio or if a
Grammar nit: "... applications that *do* not ..."

[henrika_webrtc, 2016-10-12 13:55:42]

Thanks!

One more please. Had to add API to allow enabling COMM mode from unit test to
ensure that the audio streams runs using the correct stream type. Without this
change, all output streams will be of type MUSIC and that is not the test we
want to run.

https://codereview.webrtc.org/2411263003/diff/20001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java
(right):

https://codereview.webrtc.org/2411263003/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:197:
// e.g. be suitable for applications that does not record audio or if a
On 2016/10/12 12:58:41, hlundin-webrtc wrote:
> Grammar nit: "... applications that *do* not ..."

Acknowledged.

[henrika_webrtc, 2016-10-12 14:50:58]

To clarify. Asking for one more round even if I already had l-g-t-m.

Thanks.

[hlundin-webrtc, 2016-10-12 14:58:38]

Still LGTM.

[henrika_webrtc, 2016-10-12 15:00:20]

Description was changed from

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

BUG=webrtc:4767
==========

to

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

NOTRY=TRUE

BUG=webrtc:4767
==========

[henrika_webrtc, 2016-10-12 15:00:24]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2016-10-12 15:00:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-12 15:11:44]

Description was changed from

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

NOTRY=TRUE

BUG=webrtc:4767
==========

to

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

NOTRY=TRUE

BUG=webrtc:4767
==========

[commit-bot: I haz the power, 2016-10-12 15:11:45]

Committed patchset #3 (id:10004)

[commit-bot: I haz the power, 2016-10-12 15:11:53]

Description was changed from

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

NOTRY=TRUE

BUG=webrtc:4767
==========

to

==========
Android audio playout now supports non-call media streams.

The default (preferred) stream type for output audio is STREAM_VOICE_CALL since
the WebRTC stack is mainly intended for VoIP calls. But if the user wants to run
in another mode than COMM mode, we now accept it and change the stream type to
STREAM_MUSIC instead. It can e.g. be suitable for applications that does not
record audio or if a call shall be casted to a Chromecast device.

The solution is somewhat experimental.

NOTRY=TRUE

BUG=webrtc:4767

Committed: https://crrev.com/872f614111f436d15e29516ce19c3b63d25b8639
Cr-Commit-Position: refs/heads/master@{#14613}
==========

[commit-bot: I haz the power, 2016-10-12 15:11:54]

Patchset 3 (id:??) landed as
https://crrev.com/872f614111f436d15e29516ce19c3b63d25b8639
Cr-Commit-Position: refs/heads/master@{#14613}

[henrika_webrtc, 2016-10-13 08:12:20]

A revert of this CL (patchset #3 id:10004) has been created in
https://codereview.webrtc.org/2420583002/ by henrika@webrtc.org.

The reason for reverting is: There is a risk of ending up in a bad state due to
race conditions with this patch. Tests in downstream clients have shown that it
can
happen that an output stream is opened up in MUSIC mode when it should not. 

Reverting since the new functionality added here is not worth the
risk of breaking existing clients..